Skip to content

Minor coverages improvements#2373

Merged
tomkralidis merged 9 commits into
geopython:masterfrom
webb-ben:coverage-bw
Jun 26, 2026
Merged

Minor coverages improvements#2373
tomkralidis merged 9 commits into
geopython:masterfrom
webb-ben:coverage-bw

Conversation

@webb-ben

@webb-ben webb-ben commented Jun 24, 2026

Copy link
Copy Markdown
Member

Overview

Based on #2370, introduce minor coverage improvements:

  • Add queryables to coverage
  • Add HTML representation and advertise at /collections/{cid}. This is a shallow copy of the EDR HTML template with small modifications. The HTML is served from browsers with default accept headers
image image - Advertise Coverage from /collection HTML image

Related Issue / discussion

#2370

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@webb-ben webb-ben requested review from a team and pvgenuchten June 24, 2026 22:34

@pvgenuchten pvgenuchten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanx @webb-ben, changes are usefull

let's discuss in timisuara how we can best improve the link display for a next PR

@tomkralidis can we release before foss4g-eu? a change like this would be usefull for the training

@tomkralidis

Copy link
Copy Markdown
Member

We will be releasing 0.24 after FOSS4G-EU.

@doublebyte1 doublebyte1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread pygeoapi/api/collection.py Outdated
@webb-ben webb-ben requested a review from tomkralidis June 25, 2026 13:37
@tomkralidis tomkralidis added the OGC API - Coverages OGC API - Coverages label Jun 25, 2026
@tomkralidis tomkralidis added this to the 0.24.0 milestone Jun 25, 2026
Comment thread pygeoapi/templates/collections/collection.html Outdated
Comment thread pygeoapi/templates/collections/collection.html
Comment thread pygeoapi/templates/collections/coverage/index.html
Comment thread pygeoapi/api/coverages.py Outdated

content = render_j2_template(api.tpl_config, tpl_config,
'collections/coverages/coverage.html',
'collections/coverages/index.html',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collections/coverage/index.html (and rename actual template file).

@pvgenuchten

Copy link
Copy Markdown
Contributor

Thanx @webb-ben and @tomkralidis, useful discussion and great work!

@pvgenuchten

pvgenuchten commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

the .../coverage page is nice with the coverage view, but it looks a bit empty, maybe good to repeat the title/abstract/keywords of the coverage here. The difference with the /collections/grid request page is minimal then, but should be ok.

the json and json-ld links in the top right, can we extend it to include the cov-json and grib formats? (json-ld should probably be removed, because clicking it throws invalidparamvalue, it is also used to embed schema.org on the page, this should probably also be removed, not sure if easy to remove, because this comes from inherited templates)

@webb-ben

Copy link
Copy Markdown
Member Author

The coverage HTML is a near direct copy of the EDR HTML in which the JSON-LD does not work either. I'd be interested to also return the links for these in the CovJSON (related to opengeospatial/ogcapi-environmental-data-retrieval#666)

Out of scope for this PR for sure and not sure how actually helpful it is, but there is https://covjson.org/context.jsonld

@tomkralidis tomkralidis merged commit debd17b into geopython:master Jun 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OGC API - Coverages OGC API - Coverages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants