Skip to content

ci: Pin extra test dependencies for generated test suites#6696

Open
alexander-alderman-webb wants to merge 3 commits into
masterfrom
webb/add-testing-targets
Open

ci: Pin extra test dependencies for generated test suites#6696
alexander-alderman-webb wants to merge 3 commits into
masterfrom
webb/add-testing-targets

rename var

5f4de0f
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Jun 30, 2026 in 0s

2 issues

Low

`package` and `version` parameters are dead code in `_save_to_package_dependencies_cache` - `scripts/populate_tox/populate_tox.py:296-319`

After removing name and version from the JSONL cache entry, the package and version parameters in _save_to_package_dependencies_cache are never used in the function body and should be dropped.

Unhandled KeyError crash when loading old-format cache entries missing `install_targets_hash` - `scripts/populate_tox/populate_tox.py:1274`

If a developer has a locally-generated package_dependencies.jsonl from before this schema change (entries containing name, version, constraints_hash but not install_targets_hash), line 1274 will raise an unhandled KeyError: 'install_targets_hash' with no diagnostic message guiding the developer to delete and regenerate the cache.

4 skills analyzed
Skill Findings Duration Cost
security-review 0 34.3s $0.18
code-review 0 3m 36s $0.71
find-bugs 2 8m 35s $1.79
skill-scanner 0 12.8s $0.12

⏱ 12m 59s · 1.4M in / 62.9k out · $2.79