fix: make system tray icon monochrome#1396
Open
mikejobrn wants to merge 1 commit into
Open
Conversation
Member
|
nice! would you mind sharing a screenshot of how it looks (light & dark)? |
Author
|
mikejobrn
changed the title
mikejobrn
force-pushed
the
fix-macos-tray-icon
branch
from
May 23, 2026 21:44
73fa181 to
709741b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR configures the system tray icon to render as a template on macOS, making it monochrome and allowing it to adapt dynamically to macOS light/dark themes.
Details
TrayIconBuilder::with_icon_as_template(true)using conditional compilation (#[cfg(target_os = "macos")]).with_icon_as_templateis only defined on the macOS target in thetray-iconcrate; calling it directly on Windows targets would result in compilation failures.Closes #1395