-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(antares): rebuild form controls with field primitives #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
egaitan-godaddy
wants to merge
20
commits into
main
Choose a base branch
from
refactor/field-frame
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a3e345f
refactor(antares): field primitives + ListBox, rebuild Select, align …
egaitan-godaddy 9fa71b3
chore: adding sizes
egaitan-godaddy 92c6971
chore: addressing copilot/claude feedback
egaitan-godaddy 697a820
Merge branch 'main' into refactor/field-frame
egaitan-godaddy ef9f71c
test: update visual regression screenshots
github-actions[bot] 9cc5c08
chore: addressing copilot/claude feedback
egaitan-godaddy b0228e7
refactor(antares): tidy TextFieldProps, drop props already covered by…
egaitan-godaddy d174a8c
refactor(antares): move field primitives out of _internal to componen…
egaitan-godaddy 94ebae5
refactor(antares): add typed edge prop as the FieldGroup positioning API
egaitan-godaddy ca04aaa
feat(antares): accept ReactNode for TextField leadingText/trailingText
egaitan-godaddy 2b79637
feat(antares): add FieldSelect for composite fields, sharing a trigge…
egaitan-godaddy dcb4123
feat(antares): export field composition primitives and FieldSelect
egaitan-godaddy 0fd9275
docs: document field edge prop and currency composite example
egaitan-godaddy 86fdca3
fix(antares): coerce TextField adornments to boolean (ReactNode inclu…
egaitan-godaddy a6a06bd
docs: update field-frame changeset for public primitives, edge prop, …
egaitan-godaddy a781367
chore: addressing copilot/claude feedback
egaitan-godaddy 7b9d094
refactor(antares): replace field edge prop with DOM-order corner roun…
egaitan-godaddy 7fdb450
test: update visual regression screenshots
github-actions[bot] 3267f92
refactor(antares): make FieldSelectFragment internal, drop from publi…
egaitan-godaddy 12ea4bf
chore: addressing feedback
egaitan-godaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| '@godaddy/antares': minor | ||
| --- | ||
|
|
||
| refactor(antares): field primitives + ListBox, rebuild Select, align Radio/Checkbox | ||
|
|
||
| Splits the internal field box into composable primitives — `Field`, `FieldLabel`, | ||
| `FieldGroup`, `FieldDescription`, `FieldError`, `Input`, `TextArea`, `FieldButton` — | ||
| and rebuilds `TextField`, `NumberField`, and `Select` on top. `FieldGroup` styles its | ||
| children through `data-field-group-{start,middle,end}` markers in CSS instead of | ||
| per-element RAC context injection. | ||
|
|
||
| Adds an optional `size?: 'sm' | 'md'` prop on `TextField`, `NumberField`, and | ||
| `Select`. In `sm`, the input/textarea/select font-size shrinks to `calc(1em / 1.125)`, | ||
| the input/textarea block-padding switches to `sm` (inline-padding stays at `md` so | ||
| the gutter against the border is unchanged), and `FieldButton` shrinks both axes — | ||
| keeping NumberField steppers naturally square. | ||
|
|
||
| Adds a standalone `ListBox` / `ListBoxItem` primitive. Migrates `Radio` and `Checkbox` | ||
| off the deprecated RAC `Radio` / `Checkbox` to `RadioField` + `RadioButton` / | ||
| `CheckboxField` + `CheckboxButton`. `RadioGroup` and `CheckboxGroup` now share the | ||
| field primitives for consistent label/description/error rendering. | ||
|
|
||
| Drops `Button`'s base `:not(.inline)` selector specificity by wrapping it in `:where()` to align with the rest of selectors. | ||
|
|
||
| Breaking: | ||
|
|
||
| - `Select`: drops `labelStyle`, `SelectSection`, `SelectHeader`, `items`, and | ||
| render-function children; controlled API is `value` / `onChange`. (`size` is | ||
| reintroduced under the new field-primitives cascade) | ||
| - `CheckboxGroup`: `direction` → `orientation: 'horizontal' | 'vertical'`. | ||
| - `TextField` / `NumberField` / `Select`: `description` and `errorMessage` are | ||
| `ReactNode`. | ||
94 changes: 0 additions & 94 deletions
94
packages/@godaddy/antares/components/_internal/field-frame/README.mdx
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
packages/@godaddy/antares/components/_internal/field-frame/examples/basic.tsx
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
...ges/@godaddy/antares/components/_internal/field-frame/examples/field-frame-playground.tsx
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
packages/@godaddy/antares/components/_internal/field-frame/examples/icon-accessories.tsx
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
packages/@godaddy/antares/components/_internal/field-frame/examples/leading-control.tsx
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
packages/@godaddy/antares/components/_internal/field-frame/examples/trailing-control.tsx
This file was deleted.
Oops, something went wrong.
38 changes: 0 additions & 38 deletions
38
packages/@godaddy/antares/components/_internal/field-frame/field-frame.stories.tsx
This file was deleted.
Oops, something went wrong.
95 changes: 0 additions & 95 deletions
95
packages/@godaddy/antares/components/_internal/field-frame/src/index.module.css
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.