chore: improve validateCyclic & fix on query parser & upstream resolver#579
Open
ahmadnaufal wants to merge 4 commits into
Open
chore: improve validateCyclic & fix on query parser & upstream resolver#579ahmadnaufal wants to merge 4 commits into
ahmadnaufal wants to merge 4 commits into
Conversation
ahmadnaufal
force-pushed
the
worktree-job-validate-stability-plan
branch
from
July 16, 2026 12:01
11c2c49 to
fe2547b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR's main change is to make the job cyclic dependency check work on a global optimus instance scale, not on tenant level only. With this change, there are also stability fixes on the optimus job validate
Fix cyclic dependency validation to be global-scoped
GetAllByTenantjobsJobRepository.GetAllResolvedUpstreamEdges. New detected dependencies are built usingJobService.BuildGlobalUpstreamGraphso that cyclic dependency check will also work with newly added upstreamsQuery parser: exclude UDFs / nested struct columns to be parsed as upstreams