Skip to content

chore: improve validateCyclic & fix on query parser & upstream resolver#579

Open
ahmadnaufal wants to merge 4 commits into
mainfrom
worktree-job-validate-stability-plan
Open

chore: improve validateCyclic & fix on query parser & upstream resolver#579
ahmadnaufal wants to merge 4 commits into
mainfrom
worktree-job-validate-stability-plan

Conversation

@ahmadnaufal

@ahmadnaufal ahmadnaufal commented Jul 15, 2026

Copy link
Copy Markdown

Summary

This PR's main change is to make the job cyclic dependency check work on a global optimus instance scale, not on tenant level only. With this change, there are also stability fixes on the optimus job validate

Fix cyclic dependency validation to be global-scoped

  • Cyclic dependency previously works only on tenant-level due to GetAllByTenant jobs
  • Instead of tenant only, now the cyclic checks are based on global cross-project jobs by using a new function JobRepository.GetAllResolvedUpstreamEdges. New detected dependencies are built using JobService.BuildGlobalUpstreamGraph so that cyclic dependency check will also work with newly added upstreams

Query parser: exclude UDFs / nested struct columns to be parsed as upstreams

  • Current query parser keyword-less case (needed to support comma-joined FROM a, b, c lists) had no way to tell a genuine table reference apart from any other three-dotted expression elsewhere in the query — so SELECT a.b.c, a.d.e FROM ... picked up a.b.c and a.d.e as invalid upstream tables.

@ahmadnaufal
ahmadnaufal force-pushed the worktree-job-validate-stability-plan branch from 11c2c49 to fe2547b Compare July 16, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant