Skip to content

[v18] Bump eslint from 9.39.2 to 10.4.1#67541

Merged
ravicious merged 2 commits into
branch/v18from
maja/v18/backport-67255-bump-eslint
Jun 10, 2026
Merged

[v18] Bump eslint from 9.39.2 to 10.4.1#67541
ravicious merged 2 commits into
branch/v18from
maja/v18/backport-67255-bump-eslint

Conversation

@ravicious

Copy link
Copy Markdown
Member

Backport #67255.

Manual Test Plan

Test Environment

My laptop.

Test Cases

  • pnpm lint works.

@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label Jun 8, 2026
@ravicious ravicious enabled auto-merge June 8, 2026 10:06
@socket-security

socket-security Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​eslint@​10.4.19810010095100

View full report

@nicholasmarais1158 nicholasmarais1158 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised that the diff so much bigger than #67255, but I cant see any obvious problems.

@ravicious ravicious disabled auto-merge June 10, 2026 08:35
Co-authored-by: Michael Myers <michael.myers@goteleport.com>
@ravicious ravicious force-pushed the maja/v18/backport-67255-bump-eslint branch from 3a14f7f to 5905aa7 Compare June 10, 2026 08:39
@ravicious

Copy link
Copy Markdown
Member Author

@nicholasmarais1158 It's gotten smaller after I rebased this branch on top of branch/v18. Usually I do a merge to resolve conflicts in those update PRs, but this time a merge produced a broken lockfile that pnpm couldn't parse:

$ pnpm i
Scope: all 7 workspace projects
[WARN] Ignoring broken lockfile at /Users/m/src/teleport: duplicated mapping key (2778:3)

 2775 |   '@typescript-eslint/scope-mana ...
 2776 |     resolution: {integrity: sha5 ...
 2777 |     engines: {node: ^18.18.0 ||  ...
 2778 |   '@typescript-eslint/scope-mana ...
----------^
 2779 |     resolution: {integrity: sha5 ...
 2780 |     engines: {node: ^18.18.0 ||  ...

Ignoring a lockfile is super bad because in that case pnpm is going to wholesale update all packages according to version ranges in package.json.

In any case, it's hard to say what caused the original disparity between the diffs in the lockfile. Maybe it's because we had multiple dep update PRs in flight. OTOH only one of them touched eslint packages.

@ravicious ravicious enabled auto-merge June 10, 2026 08:44
@ravicious ravicious added this pull request to the merge queue Jun 10, 2026
Merged via the queue into branch/v18 with commit 377401b Jun 10, 2026
42 checks passed
@ravicious ravicious deleted the maja/v18/backport-67255-bump-eslint branch June 10, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants