[v18] Bump eslint from 9.39.2 to 10.4.1#67541
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
nicholasmarais1158
left a comment
There was a problem hiding this comment.
I'm a little surprised that the diff so much bigger than #67255, but I cant see any obvious problems.
Co-authored-by: Michael Myers <michael.myers@goteleport.com>
3a14f7f to
5905aa7
Compare
|
@nicholasmarais1158 It's gotten smaller after I rebased this branch on top of branch/v18. Usually I do a merge to resolve conflicts in those update PRs, but this time a merge produced a broken lockfile that pnpm couldn't parse: Ignoring a lockfile is super bad because in that case pnpm is going to wholesale update all packages according to version ranges in package.json. In any case, it's hard to say what caused the original disparity between the diffs in the lockfile. Maybe it's because we had multiple dep update PRs in flight. OTOH only one of them touched eslint packages. |
Backport #67255.
Manual Test Plan
Test Environment
My laptop.
Test Cases
pnpm lintworks.