Use session duration to calculate session timeout#5446
Merged
Conversation
THIS REQUIRES A NEW GSAD VERSION! When the system time of the machine running gsad and the users system time where the browser is running GSA is not in sync the session timeout has been displayed incorrectly. Either it did show 0:00 and the session was still valid or the user has been logged out early. With this change the session timeout is calculated by getting the duration instead of the end time.
greenbonebot
enabled auto-merge (rebase)
July 24, 2026 12:15
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5446 +/- ##
==========================================
- Coverage 81.28% 81.28% -0.01%
==========================================
Files 1280 1280
Lines 33322 33321 -1
Branches 9920 9919 -1
==========================================
- Hits 27085 27084 -1
Misses 5565 5565
Partials 672 672 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use session duration to calculate session timeout
THIS CHANGE REQUIRES A NEW GSAD VERSION!
Why
When the system time of the machine running gsad and the users system time where the browser is running GSA is not in sync the session timeout has been displayed incorrectly. Either it did show 0:00 and the session was still valid or the user has been logged out early. With this change the session timeout is calculated by getting the duration instead of the end time.
References
https://jira.greenbone.net/browse/GEA-1743
greenbone/gsad#433
Checklist