r/aws_apigatewayv2_integration: Add Resource Identity and List Resource support#48425
Open
brkcvlk wants to merge 4 commits into
Open
r/aws_apigatewayv2_integration: Add Resource Identity and List Resource support#48425brkcvlk wants to merge 4 commits into
brkcvlk wants to merge 4 commits into
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
brkcvlk
commented
Jun 16, 2026
| if uri := aws.ToString(item.IntegrationUri); uri != "" { | ||
| displayName = fmt.Sprintf("%s %s", displayName, uri) | ||
| } | ||
| result.DisplayName = displayName |
Author
There was a problem hiding this comment.
Unsure about the best value for result.DisplayName, I concatenated integrationType and URI, inspired by how it's handled in resource/aws_api_gateway_integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds Resource Identity and List Resource support for
aws_apigatewayv2_integration.I tried to keep the implementation consistent with #47452 and #47441 .
I only realized later that work related to #47005 was generally being tracked through dedicated issues. If maintainers would prefer that workflow, I'm happy to have this PR closed and follow that process instead.
Relations
Relates #47005
References
Output from Acceptance Testing
List