Skip to content

r/aws_apigatewayv2_integration: Add Resource Identity and List Resource support#48425

Open
brkcvlk wants to merge 4 commits into
hashicorp:mainfrom
brkcvlk:f-list-resource-aws_apigatewayv2_integration
Open

r/aws_apigatewayv2_integration: Add Resource Identity and List Resource support#48425
brkcvlk wants to merge 4 commits into
hashicorp:mainfrom
brkcvlk:f-list-resource-aws_apigatewayv2_integration

Conversation

@brkcvlk

@brkcvlk brkcvlk commented Jun 16, 2026

Copy link
Copy Markdown

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds Resource Identity and List Resource support for aws_apigatewayv2_integration.

I tried to keep the implementation consistent with #47452 and #47441 .

I only realized later that work related to #47005 was generally being tracked through dedicated issues. If maintainers would prefer that workflow, I'm happy to have this PR closed and follow that process instead.

Relations

Relates #47005

References

Output from Acceptance Testing

List

% make testacc TESTS=TestAccAPIGatewayV2Integration_List PKG=apigatewayv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_apigatewayv2_integration 🌿...
TF_ACC=1 go1.26.4 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2I
ntegration_List'  -timeout 360m -vet=off -buildvcs=false
2026/06/16 14:16:15 Creating Terraform AWS Provider (SDKv2-style)...
2026/06/16 14:16:15 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAPIGatewayV2Integration_List_basic
=== PAUSE TestAccAPIGatewayV2Integration_List_basic
=== RUN   TestAccAPIGatewayV2Integration_List_includeResource
=== PAUSE TestAccAPIGatewayV2Integration_List_includeResource
=== RUN   TestAccAPIGatewayV2Integration_List_regionOverride
=== PAUSE TestAccAPIGatewayV2Integration_List_regionOverride
=== CONT  TestAccAPIGatewayV2Integration_List_basic
=== CONT  TestAccAPIGatewayV2Integration_List_regionOverride
=== CONT  TestAccAPIGatewayV2Integration_List_includeResource
--- PASS: TestAccAPIGatewayV2Integration_List_basic (33.52s)
--- PASS: TestAccAPIGatewayV2Integration_List_includeResource (33.93s)
--- PASS: TestAccAPIGatewayV2Integration_List_regionOverride (34.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       80.333s
...
%  make testacc TESTS=TestAccAPIGatewayV2Integration_ PKG=apigatewayv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_apigatewayv2_integration 🌿...
TF_ACC=1 go1.26.4 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2Integration_'  -timeout 360m -vet=off -buildvcs=false
2026/06/16 14:19:04 Creating Terraform AWS Provider (SDKv2-style)...
2026/06/16 14:19:04 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAPIGatewayV2Integration_Identity_basic
=== PAUSE TestAccAPIGatewayV2Integration_Identity_basic
=== RUN   TestAccAPIGatewayV2Integration_Identity_regionOverride
=== PAUSE TestAccAPIGatewayV2Integration_Identity_regionOverride
=== RUN   TestAccAPIGatewayV2Integration_Identity_ExistingResource_basic
=== PAUSE TestAccAPIGatewayV2Integration_Identity_ExistingResource_basic
=== RUN   TestAccAPIGatewayV2Integration_Identity_ExistingResource_noRefreshNoChange
=== PAUSE TestAccAPIGatewayV2Integration_Identity_ExistingResource_noRefreshNoChange
=== RUN   TestAccAPIGatewayV2Integration_List_basic
=== PAUSE TestAccAPIGatewayV2Integration_List_basic
=== RUN   TestAccAPIGatewayV2Integration_List_includeResource
=== PAUSE TestAccAPIGatewayV2Integration_List_includeResource
=== RUN   TestAccAPIGatewayV2Integration_List_regionOverride
=== PAUSE TestAccAPIGatewayV2Integration_List_regionOverride
=== RUN   TestAccAPIGatewayV2Integration_basicWebSocket
=== PAUSE TestAccAPIGatewayV2Integration_basicWebSocket
=== RUN   TestAccAPIGatewayV2Integration_basicHTTP
=== PAUSE TestAccAPIGatewayV2Integration_basicHTTP
=== RUN   TestAccAPIGatewayV2Integration_disappears
=== PAUSE TestAccAPIGatewayV2Integration_disappears
=== RUN   TestAccAPIGatewayV2Integration_dataMappingHTTP
=== PAUSE TestAccAPIGatewayV2Integration_dataMappingHTTP
=== RUN   TestAccAPIGatewayV2Integration_integrationTypeHTTP
=== PAUSE TestAccAPIGatewayV2Integration_integrationTypeHTTP
=== RUN   TestAccAPIGatewayV2Integration_lambdaWebSocket
=== PAUSE TestAccAPIGatewayV2Integration_lambdaWebSocket
=== RUN   TestAccAPIGatewayV2Integration_lambdaHTTP
=== PAUSE TestAccAPIGatewayV2Integration_lambdaHTTP
=== RUN   TestAccAPIGatewayV2Integration_vpcLinkWebSocket
=== PAUSE TestAccAPIGatewayV2Integration_vpcLinkWebSocket
=== RUN   TestAccAPIGatewayV2Integration_vpcLinkHTTP
=== PAUSE TestAccAPIGatewayV2Integration_vpcLinkHTTP
=== RUN   TestAccAPIGatewayV2Integration_serviceIntegration
=== PAUSE TestAccAPIGatewayV2Integration_serviceIntegration
=== CONT  TestAccAPIGatewayV2Integration_Identity_basic
=== CONT  TestAccAPIGatewayV2Integration_disappears
=== CONT  TestAccAPIGatewayV2Integration_lambdaHTTP
=== CONT  TestAccAPIGatewayV2Integration_lambdaWebSocket
=== CONT  TestAccAPIGatewayV2Integration_dataMappingHTTP
=== CONT  TestAccAPIGatewayV2Integration_Identity_ExistingResource_noRefreshNoChange
=== CONT  TestAccAPIGatewayV2Integration_vpcLinkHTTP
=== CONT  TestAccAPIGatewayV2Integration_Identity_ExistingResource_basic
=== CONT  TestAccAPIGatewayV2Integration_List_includeResource
=== CONT  TestAccAPIGatewayV2Integration_vpcLinkWebSocket
=== CONT  TestAccAPIGatewayV2Integration_serviceIntegration
=== CONT  TestAccAPIGatewayV2Integration_basicHTTP
=== CONT  TestAccAPIGatewayV2Integration_Identity_regionOverride
=== CONT  TestAccAPIGatewayV2Integration_List_basic
=== CONT  TestAccAPIGatewayV2Integration_basicWebSocket
=== CONT  TestAccAPIGatewayV2Integration_List_regionOverride
=== CONT  TestAccAPIGatewayV2Integration_integrationTypeHTTP
--- PASS: TestAccAPIGatewayV2Integration_List_regionOverride (117.50s)
--- PASS: TestAccAPIGatewayV2Integration_List_includeResource (125.50s)
--- PASS: TestAccAPIGatewayV2Integration_List_basic (131.65s)
--- PASS: TestAccAPIGatewayV2Integration_disappears (131.85s)
--- PASS: TestAccAPIGatewayV2Integration_basicHTTP (132.07s)
--- PASS: TestAccAPIGatewayV2Integration_basicWebSocket (137.87s)
--- PASS: TestAccAPIGatewayV2Integration_lambdaHTTP (160.78s)
--- PASS: TestAccAPIGatewayV2Integration_lambdaWebSocket (165.33s)
--- PASS: TestAccAPIGatewayV2Integration_Identity_regionOverride (185.41s)
--- PASS: TestAccAPIGatewayV2Integration_dataMappingHTTP (185.66s)
--- PASS: TestAccAPIGatewayV2Integration_Identity_basic (187.13s)
--- PASS: TestAccAPIGatewayV2Integration_integrationTypeHTTP (195.32s)
--- PASS: TestAccAPIGatewayV2Integration_Identity_ExistingResource_basic (260.50s)
--- PASS: TestAccAPIGatewayV2Integration_Identity_ExistingResource_noRefreshNoChange (262.63s)
--- PASS: TestAccAPIGatewayV2Integration_vpcLinkHTTP (315.13s)
--- PASS: TestAccAPIGatewayV2Integration_serviceIntegration (326.16s)
--- PASS: TestAccAPIGatewayV2Integration_vpcLinkWebSocket (615.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       633.900s

@brkcvlk brkcvlk requested a review from a team as a code owner June 16, 2026 13:47
@dosubot dosubot Bot added the new-list-resource Introduces list resource support. label Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jun 16, 2026
if uri := aws.ToString(item.IntegrationUri); uri != "" {
displayName = fmt.Sprintf("%s %s", displayName, uri)
}
result.DisplayName = displayName

@brkcvlk brkcvlk Jun 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the best value for result.DisplayName, I concatenated integrationType and URI, inspired by how it's handled in resource/aws_api_gateway_integration.

@justinretzolk justinretzolk added resource-identity Pertains to resource identity. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. resource-identity Pertains to resource identity. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants