Skip to content

[New Resource] Aws Prometheus Anomaly Detector - #49139

Open
brosas07 wants to merge 41 commits into
mainfrom
aws_prometheus_anomaly_detector
Open

[New Resource] Aws Prometheus Anomaly Detector#49139
brosas07 wants to merge 41 commits into
mainfrom
aws_prometheus_anomaly_detector

Conversation

@brosas07

@brosas07 brosas07 commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Closes #45764

References

Output from Acceptance Testing

% make t T=TestAccAMPAnomalyDetector_ K=amp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 aws_prometheus_anomaly_detector 🌿...
TF_ACC=1 go1.26.5 test ./internal/service/amp/... -v -count 1 -parallel 20 -run='TestAccAMPAnomalyDetector_'  -timeout 360m -vet=off
2026/07/27 15:14:10 Creating Terraform AWS Provider (SDKv2-style)...
2026/07/27 15:14:10 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAMPAnomalyDetector_Identity_basic
=== PAUSE TestAccAMPAnomalyDetector_Identity_basic
=== RUN   TestAccAMPAnomalyDetector_Identity_regionOverride
=== PAUSE TestAccAMPAnomalyDetector_Identity_regionOverride
=== RUN   TestAccAMPAnomalyDetector_List_basic
=== PAUSE TestAccAMPAnomalyDetector_List_basic
=== RUN   TestAccAMPAnomalyDetector_List_includeResource
=== PAUSE TestAccAMPAnomalyDetector_List_includeResource
=== RUN   TestAccAMPAnomalyDetector_List_regionOverride
=== PAUSE TestAccAMPAnomalyDetector_List_regionOverride
=== RUN   TestAccAMPAnomalyDetector_List_aliasFilter
=== PAUSE TestAccAMPAnomalyDetector_List_aliasFilter
=== RUN   TestAccAMPAnomalyDetector_List_workspaceFilter
=== PAUSE TestAccAMPAnomalyDetector_List_workspaceFilter
=== RUN   TestAccAMPAnomalyDetector_tags
=== PAUSE TestAccAMPAnomalyDetector_tags
=== RUN   TestAccAMPAnomalyDetector_Tags_null
=== PAUSE TestAccAMPAnomalyDetector_Tags_null
=== RUN   TestAccAMPAnomalyDetector_Tags_emptyMap
=== PAUSE TestAccAMPAnomalyDetector_Tags_emptyMap
=== RUN   TestAccAMPAnomalyDetector_Tags_addOnUpdate
=== PAUSE TestAccAMPAnomalyDetector_Tags_addOnUpdate
=== RUN   TestAccAMPAnomalyDetector_Tags_EmptyTag_onCreate
=== PAUSE TestAccAMPAnomalyDetector_Tags_EmptyTag_onCreate
=== RUN   TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_add
=== PAUSE TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_add
=== RUN   TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_replace
=== PAUSE TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_replace
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_providerOnly
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_providerOnly
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_nonOverlapping
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_overlapping
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_overlapping
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAMPAnomalyDetector_Tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAMPAnomalyDetector_Tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAMPAnomalyDetector_Tags_ComputedTag_onCreate
=== PAUSE TestAccAMPAnomalyDetector_Tags_ComputedTag_onCreate
=== RUN   TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_add
=== PAUSE TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_add
=== RUN   TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_replace
=== PAUSE TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_replace
=== RUN   TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_defaultTag
=== PAUSE TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_defaultTag
=== RUN   TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_resourceTag
=== PAUSE TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_resourceTag
=== RUN   TestAccAMPAnomalyDetector_basic
=== PAUSE TestAccAMPAnomalyDetector_basic
=== RUN   TestAccAMPAnomalyDetector_disappears
=== PAUSE TestAccAMPAnomalyDetector_disappears
=== RUN   TestAccAMPAnomalyDetector_update
=== PAUSE TestAccAMPAnomalyDetector_update
=== RUN   TestAccAMPAnomalyDetector_randomCutForest
=== PAUSE TestAccAMPAnomalyDetector_randomCutForest
=== RUN   TestAccAMPAnomalyDetector_labels
=== PAUSE TestAccAMPAnomalyDetector_labels
=== CONT  TestAccAMPAnomalyDetector_Identity_basic
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_replace
=== CONT  TestAccAMPAnomalyDetector_Tags_emptyMap
=== CONT  TestAccAMPAnomalyDetector_disappears
=== CONT  TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_resourceTag
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_overlapping
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_providerOnly
=== CONT  TestAccAMPAnomalyDetector_basic
=== CONT  TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_replace
=== CONT  TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_defaultTag
=== CONT  TestAccAMPAnomalyDetector_Tags_EmptyTag_onCreate
=== CONT  TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_add
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_nonOverlapping
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_add
=== CONT  TestAccAMPAnomalyDetector_Tags_ComputedTag_onCreate
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccAMPAnomalyDetector_Tags_addOnUpdate
=== CONT  TestAccAMPAnomalyDetector_tags
--- PASS: TestAccAMPAnomalyDetector_Tags_ComputedTag_onCreate (83.39s)
=== CONT  TestAccAMPAnomalyDetector_Tags_null
--- PASS: TestAccAMPAnomalyDetector_disappears (87.39s)
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyResourceTag
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_nullOverlappingResourceTag (99.20s)
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccAMPAnomalyDetector_basic (100.84s)
=== CONT  TestAccAMPAnomalyDetector_randomCutForest
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_nullNonOverlappingResourceTag (101.16s)
=== CONT  TestAccAMPAnomalyDetector_labels
--- PASS: TestAccAMPAnomalyDetector_Tags_emptyMap (108.75s)
=== CONT  TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_replace (138.74s)
=== CONT  TestAccAMPAnomalyDetector_List_workspaceFilter
--- PASS: TestAccAMPAnomalyDetector_Identity_basic (144.67s)
=== CONT  TestAccAMPAnomalyDetector_List_aliasFilter
--- PASS: TestAccAMPAnomalyDetector_Tags_addOnUpdate (150.94s)
=== CONT  TestAccAMPAnomalyDetector_List_includeResource
--- PASS: TestAccAMPAnomalyDetector_Tags_ComputedTag_OnUpdate_add (157.38s)
=== CONT  TestAccAMPAnomalyDetector_update
--- PASS: TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_replace (169.82s)
=== CONT  TestAccAMPAnomalyDetector_List_regionOverride
--- PASS: TestAccAMPAnomalyDetector_Tags_null (91.17s)
=== CONT  TestAccAMPAnomalyDetector_List_basic
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyResourceTag (92.13s)
=== CONT  TestAccAMPAnomalyDetector_Identity_regionOverride
--- PASS: TestAccAMPAnomalyDetector_Tags_EmptyTag_onCreate (179.55s)
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToProviderOnly (181.44s)
--- PASS: TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_defaultTag (185.51s)
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_emptyProviderOnlyTag (90.04s)
--- PASS: TestAccAMPAnomalyDetector_List_workspaceFilter (69.01s)
--- PASS: TestAccAMPAnomalyDetector_List_aliasFilter (66.83s)
--- PASS: TestAccAMPAnomalyDetector_List_includeResource (65.26s)
--- PASS: TestAccAMPAnomalyDetector_labels (120.44s)
--- PASS: TestAccAMPAnomalyDetector_randomCutForest (122.30s)
--- PASS: TestAccAMPAnomalyDetector_Tags_IgnoreTags_Overlap_resourceTag (227.49s)
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_nonOverlapping (228.56s)
--- PASS: TestAccAMPAnomalyDetector_List_regionOverride (59.33s)
--- PASS: TestAccAMPAnomalyDetector_List_basic (56.35s)
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_overlapping (231.57s)
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_updateToResourceOnly (124.21s)
--- PASS: TestAccAMPAnomalyDetector_Tags_EmptyTag_OnUpdate_add (235.05s)
--- PASS: TestAccAMPAnomalyDetector_Identity_regionOverride (65.61s)
--- PASS: TestAccAMPAnomalyDetector_Tags_DefaultTags_providerOnly (252.19s)
--- PASS: TestAccAMPAnomalyDetector_tags (254.57s)
--- PASS: TestAccAMPAnomalyDetector_update (112.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	278.328s

...

brosas07 added 27 commits July 24, 2026 13:35
@brosas07
Did Data Structure section
4f2b561
@brosas07
Added Schema() modeled after the data structures
7648552
@brosas07
Removed timeouts
677821a
@brosas07
Added Create() function
dc0a138
@brosas07
Added Read() function and timeouts re-added
f8689f0
@brosas07
Updated statusAnomalyDetector and waitAnomalyDetector functions
a8865d0
@brosas07
Added Update() function
09f4397
@brosas07
Added Delete() function
1c580e5
@brosas07
Fixed red marks
c8ee9e9
@brosas07
Working on basic test
13ceab3
@brosas07
Fixed basic test errors
f0bc8ce
@brosas07
Fixed the disappears test and the rest of the tests generated by go g…
bf2bcda 
…enerate
@brosas07
Update test added and passed
0673828
@brosas07
Added RandomCutForest test and passed
9c5dd09
@brosas07
Added labels test and passed
59e32bb
@brosas07
Wrote sweeper code, removed testAccPreCheck, and renamed doc from amp…
0fa75dc 
… to prometheus
@brosas07
Moved sweeper func to sweep.go
af37cf4
@brosas07
Added config base const to test configs
61b540b
@brosas07
Removed comments and status, added status reason output to waiters, p…
54d6d40 
…lanmodifiers on computed, and prefix to Expand and Flatten calls
@brosas07
Wrote the documentation and passed swissshepherd check
322b6a0
@brosas07
Make fmt changes
f60ae7c
@brosas07
Added anomaly detector list resource (no testing or docs yet)
ee2179b
@brosas07
Ran generated list tests and passed
7a51e9f
@brosas07
Added list alias filter test
46e3c6b
@brosas07
Added workspace filter test
d6f29e5
@brosas07
Wrote documentation and removed tip comments
4629a66
@brosas07
Made swissshepherd fix
d5fef93
@brosas07
brosas07 requested a review from a team as a code owner July 27, 2026 20:45
@dosubot dosubot Bot added new-list-resource Introduces list resource support. new-resource Introduces a new resource. labels Jul 27, 2026
@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. service/amp Issues and PRs that pertain to the amp service. size/XL Managed by automation to categorize the size of a PR. labels Jul 27, 2026
@brosas07 brosas07 changed the title Aws prometheus anomaly detector [New Resource] Aws Prometheus Anomaly Detector Jul 28, 2026
johnsonaj
johnsonaj reviewed Jul 28, 2026
View reviewed changes
Comment thread .changelog/#49139.txt Outdated
johnsonaj
johnsonaj reviewed Jul 28, 2026
View reviewed changes
Comment thread .changelog/49139.txt
taruntej-a
taruntej-a reviewed Jul 28, 2026
View reviewed changes
Comment thread internal/service/amp/testdata/tmpl/anomaly_detector_basic.gtpl
taruntej-a
taruntej-a reviewed Jul 28, 2026
View reviewed changes
Comment thread internal/service/amp/anomaly_detector.go Outdated
@brosas07
brosas07 requested review from johnsonaj and taruntej-a July 28, 2026 16:27
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 28, 2026
YakDriver
YakDriver requested changes Jul 28, 2026
View reviewed changes

@YakDriver YakDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few items to address

Comment thread internal/service/amp/anomaly_detector.go Outdated
Comment thread internal/service/amp/anomaly_detector.go Outdated
Comment thread internal/service/amp/anomaly_detector.go Outdated
Comment thread internal/service/amp/anomaly_detector.go Outdated
Comment thread internal/service/amp/anomaly_detector_test.go Outdated
Comment thread internal/service/amp/anomaly_detector.go Outdated
Comment thread internal/service/amp/anomaly_detector_list.go Outdated
subham-ibmhc
subham-ibmhc reviewed Jul 29, 2026
View reviewed changes
Comment thread internal/service/amp/anomaly_detector.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subham-ibmhc subham-ibmhc subham-ibmhc left review comments
@YakDriver YakDriver YakDriver requested changes
@johnsonaj johnsonaj Awaiting requested review from johnsonaj
@taruntej-a taruntej-a Awaiting requested review from taruntej-a

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. new-resource Introduces a new resource. service/amp Issues and PRs that pertain to the amp service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Resource: aws_prometheus_anomaly_detector

6 participants

@brosas07 @johnsonaj @YakDriver @taruntej-a @subham-ibmhc @ewbankkit