feat: Add support for universe_domain parameter (#242)#243
Draft
matgou wants to merge 3 commits into
Draft
Conversation
This commit introduces a new `universe_domain` parameter to the plugin configuration, allowing users to specify the Google Cloud environment for client connections. This enables support for specialized offerings and sovereign controls beyond the default googleapis.com. Key changes: - Added `universe_domain` field to the plugin configuration. - Modified IAM client creation to use the configured `universe_domain`. - Updated credentials parsing to utilize `cloud.google.com/go/auth/credentials.DetectDefault` and support local-signing JWT generation. - Adjusted token generation to use `cloud.google.com/go/auth/credentials.DetectDefault` for credential handling.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This commit introduces a new
universe_domainparameter to the plugin configuration, allowing users to specify the Google Cloud environment for client connections. This enables support for specialized offerings and sovereign controls beyond the default googleapis.com.Design of Change
universe_domainfield to the plugin configuration.universe_domain.cloud.google.com/go/auth/credentials.DetectDefaultand support local-signing JWT generation.cloud.google.com/go/auth/credentials.DetectDefaultfor credential handling.Related Issues/Pull Requests
[ ] Issue #242 Feature Request: Support universe_domain for Sovereign Google Cloud Environments
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[ ] Backwards compatible