Reject software wgpu adapters to allow renderer fallback#3365
Open
zao111222333 wants to merge 2 commits into
Open
Reject software wgpu adapters to allow renderer fallback#3365zao111222333 wants to merge 2 commits into
zao111222333 wants to merge 2 commits into
Conversation
Contributor
|
This feels like it should only happen if |
Author
That's more reasonable, is there any "fallback or not" option in iced? So I can reuse that configuration |
Contributor
If |
Author
|
Now it only rejects software wgpu adapters when the tiny-skia fallback is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents
iced_wgpufrom selecting software-rendered wgpu adapters, such asllvmpipe (LLVM 17.0.2, 256 bits)onRed Hat 8.10, as the primary renderer.Previously, when
Backend::Bestwas used, the fallback compositor triedwgpufirst. If wgpu successfully created an adapter backed byllvmpipe, iced treated it as a valid wgpu renderer and never fell back totiny-skia.The change now:
wgpu::DeviceType::Cpullvmpipe,lavapipe,softpipe, andswiftshaderllvmpiperejection and normal hardware adapter acceptance