i18n: add Korean (ko) translation#578
Conversation
Adds a complete Korean locale (web/src/i18n/locales/ko.json) mirroring
the full key structure of en.json (1340 leaf keys, 0 missing/extra),
with interpolation placeholders and inline tags verified to match
exactly. Registers ko in the i18next resource map (i18n/config.ts)
and the language switcher dropdown (LanguageSwitcher).
Verified with:
- python key-set diff (en vs ko): 0 missing, 0 extra
- python placeholder/tag diff ({{var}}, <1>...</1>): 0 mismatches
- pnpm vitest run (full suite): 180 files / 609 tests passed
- tsc --noEmit: no errors
- eslint on changed files: no issues
search.sort.stars was translated as "평점" (rating) instead of a star-count term, conflating it with the separate rating concept used elsewhere (e.g. skillDetail.rating). Changed to "즐겨찾기순" for consistency with the "즐겨찾기" (starred) terminology used across the other 60+ star-related keys in this file.
|
|
1 similar comment
|
|
|
CI is approved and running now. One thing left on your side: please sign the CLA (see the license/cla check link) so this can merge once checks are green. |
|
Update after approving CI: besides the CLA, the DCO check fails (commits need Signed-off-by — |
Korean (ko) translation PR body template
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
web/src/i18n/locales/ko.jsonwith a full Korean translation (1340 keys, 1:1 parity withen.json)koinweb/src/i18n/config.tsi18next resources한국어) to the language switcher inweb/src/shared/components/language-switcher.tsxTesting
en.jsonandko.jsonboth have exactly 1340 keys, 0 missing/extra{{variable}}placeholders and<1>...</1>style tags match betweenen.jsonandko.jsonpnpm vitest run— 180 files / 609 tests passingpnpm typecheck(tsc --noEmit) — cleanpnpm lint(eslint) — clean