Skip to content

replace go-dsqueue#1177

Draft
gammazero wants to merge 5 commits into
mainfrom
cascadeq-for-provide
Draft

replace go-dsqueue#1177
gammazero wants to merge 5 commits into
mainfrom
cascadeq-for-provide

Conversation

@gammazero

@gammazero gammazero commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Replace the provide queue use of go-dsqueue with cascadeq, in boxo and go-libp2p-kad-dht

⚠️ DO NOT MERGE. This is an experiment to determine if changing the provide queue implementation has sufficient benefit to justify make this change. The intended benefits are:

  • Overall efficiency (faster, less memory overhead)
  • Reliable performance regardless of datastore in use

@socket-security

socket-security Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedgithub.com/​gammazero/​cascadeq@​v0.2.099100100100100
Updatedgithub.com/​libp2p/​go-libp2p-kad-dht@​v0.40.0 ⏵ v0.40.1-0.20260617160602-96c8548a5e2a100 +1100100100100

View full report

@gammazero gammazero changed the title Cascadeq for provide replace go-dsqueue Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.63%. Comparing base (a88ea29) to head (61157c9).

Files with missing lines Patch % Lines
provider/reprovider.go 58.33% 3 Missing and 2 partials ⚠️
provider/noop.go 0.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   63.58%   63.63%   +0.05%     
==========================================
  Files         268      268              
  Lines       26964    26972       +8     
==========================================
+ Hits        17144    17164      +20     
+ Misses       8102     8095       -7     
+ Partials     1718     1713       -5     
Files with missing lines Coverage Δ
provider/provider.go 90.16% <ø> (ø)
provider/noop.go 0.00% <0.00%> (ø)
provider/reprovider.go 58.09% <58.33%> (-0.24%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant