Skip to content

Improve proto field summary descriptions #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajeshd2091 wants to merge 1 commit into
base: master
Choose a base branch
from
+44 −72
Open

Improve proto field summary descriptions #3732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 12 additions & 48 deletions kubernetes/customresourcedefinitions.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 12 additions & 8 deletions networking/v1alpha3/virtual_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions networking/v1alpha3/virtual_service.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 12 additions & 8 deletions networking/v1alpha3/virtual_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,8 +738,9 @@ message HTTPMatchRequest {
// the access logs for requests matching this route.
string name = 11;

// URI to match
// values are case-sensitive and formatted as follows:
// URI to match.
//
// Values are case-sensitive and formatted as follows:
//
// - `exact: "value"` for exact string match
//
Expand All @@ -751,8 +752,9 @@ message HTTPMatchRequest {
// `ignoreUriCase` flag.
StringMatch uri = 1;

// URI Scheme
// values are case-sensitive and formatted as follows:
// URI Scheme.
//
// Values are case-sensitive and formatted as follows:
//
// - `exact: "value"` for exact string match
//
Expand All @@ -762,8 +764,9 @@ message HTTPMatchRequest {
//
StringMatch scheme = 2;

// HTTP Method
// values are case-sensitive and formatted as follows:
// HTTP Method.
//
// Values are case-sensitive and formatted as follows:
//
// - `exact: "value"` for exact string match
//
Expand All @@ -773,8 +776,9 @@ message HTTPMatchRequest {
//
StringMatch method = 3;

// HTTP Authority
// values are case-sensitive and formatted as follows:
// HTTP Authority.
//
// Values are case-sensitive and formatted as follows:
//
// - `exact: "value"` for exact string match
//
Expand Down