Skip to content

Add CI targets for updated Clang and MSVC compilers #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbcoe wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add CI targets for updated Clang and MSVC compilers #603

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be35ede
Add CI targets for newer compilers
jbcoe Oct 29, 2025
d0c4d4c
Fix failing CI for GitHub action validation
jbcoe Oct 29, 2025
38bfe6a
Remove addition of GCC-15 as it is not installed on the test runners
jbcoe Oct 30, 2025
cb7ddc5
Merge branch 'main' into dev-jbcoe-github-ci-compiler-additions
jbcoe Nov 7, 2025
5928396
Re-enable GCC-15
jbcoe Nov 7, 2025
2a489a2
Merge branch 'dev-jbcoe-github-ci-compiler-additions' of github.com:j…
jbcoe Nov 7, 2025
bd5fc38
Merge branch 'main' into dev-jbcoe-github-ci-compiler-additions
jbcoe Jan 22, 2026
e773963
Merge branch 'main' into dev-jbcoe-github-ci-compiler-additions
jbcoe Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/clang-tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ on:
branches: [main]
paths-ignore:
- CODEOWNERS
- requirements.txt
- LICENSE.txt
- .pre-commit-config.yaml
- "**/*.md"
pull_request:
branches: [main]
paths-ignore:
- CODEOWNERS
- requirements.txt
- LICENSE.txt
- .pre-commit-config.yaml
- "**/*.md"
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,19 @@ jobs:
},
lib: "libstdc++14",
}
# - {

@Twon Twon Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, GCC-15 is not yet supported in the latest supported version of Ubuntu? Should we remove this until it's supported?

@jbcoe jbcoe Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a reminder if left as is but we can do that with an issue. Probably best removed.

As you say, runners don't have the compiler version (yet).

@jbcoe jbcoe Nov 7, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the comments and leave this PR open until CI passes.

# name: "Ubuntu GCC-15",
# os: ubuntu-24.04,
# compiler:
# {
# type: GCC,
# version: 15,
# cc: "gcc-15",
# cxx: "g++-15",
# std: 20,
# },
# lib: "libstdc++15",
# }
- {
name: "Ubuntu Clang-17 + libc++",
os: ubuntu-24.04,
Expand Down Expand Up @@ -122,6 +135,19 @@ jobs:
},
lib: "libc++19",
}
- {
name: "Ubuntu Clang-20 + libc++",
os: ubuntu-24.04,
compiler:
{
type: CLANG,
version: 20,
cc: "clang-20",
cxx: "clang++-20",
std: 20,
},
lib: "libc++20",
}
- {
name: "Visual Studio 2019",
os: windows-latest,
Expand All @@ -142,6 +168,11 @@ jobs:
os: windows-latest,
compiler: { type: VISUAL, version: 19, cc: "cl", cxx: "cl" },
}
- {
name: "Visual Studio 2022 v20",
os: windows-latest,
compiler: { type: VISUAL, version: 20, cc: "cl", cxx: "cl", std: 20 },

Copilot AI Nov 7, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The std: 20 field is inconsistent with other Visual Studio entries (v16, v17, v18, v19) which don't include this field. For consistency with the existing pattern, either remove this field from the v20 entry or add it to all other Visual Studio entries. The field appears to not be used by the workflow steps, as the CMake configuration is handled by presets.

Suggested change
compiler: { type: VISUAL, version: 20, cc: "cl", cxx: "cl", std: 20 },
compiler: { type: VISUAL, version: 20, cc: "cl", cxx: "cl" },

Copilot uses AI. Check for mistakes.
}
- {
name: "MacOS Apple Clang 15",
os: macos-14,
Expand All @@ -154,6 +185,18 @@ jobs:
std: 20,
},
}
- {
name: "MacOS Apple Clang 16",
os: macos-14,
compiler:
{
type: APPLE_CLANG,
version: "16.0",
cc: "clang",
cxx: "clang++",
std: 20,
},
}
steps:
- uses: actions/checkout@v4
- uses: seanmiddleditch/gha-setup-ninja@master
Expand Down