Potential Vulnerability in Cloned Code#80
Open
navnitan-7 wants to merge 1 commit into
Open
Conversation
Skip script conversion on cross-domain responses unless dataType is explicitly script, matching jquery/jquery@2546bb35 (gh-2432). Made-with: Cursor
|
@navnitan-7 is attempting to deploy a commit to the kangvcar's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Potential CVE-2015-9251 alignment in vendored jQuery (
extension/js/jquery.js): cross-domain Ajax could treat responses as executable script when conversion inferreddataType"script".Affected code
extension/js/jquery.jsajaxConvert(inside thewhile ( current )loop, branchprev !== "*" && prev !== current)Changes
Mirror the upstream jQuery fix: when the request is cross-domain (
s.crossDomain) and the next inferred type is"script", skip that conversion step (continue) so the response is not executed as script unless the caller explicitly setdataType: "script".Original fix: jquery/jquery@2546bb35 (mitigates gh-2432).
Impact
Reduces XSS risk for consumers of this bundled jQuery when using
$.ajax/ related APIs against cross-origin endpoints without an explicit scriptdataType.References