feat: implement redesigned Gym Support Content and update PageHeader …#172
Hidden character warning
Conversation
…for improved subtitle handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughGymSupportContent.tsx is refactored to use new helper components (SectionCard, Paragraph, TextList, NoticeBox) for rendering sections, removing the description intro. PageHeaderProps now accepts React.ReactNode for subtitle/description. The sportpalya-tamogatas page passes a parsed subtitle and content variable to its components. ChangesSportpálya támogatás page redesign
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/common/PageHeader.tsx (1)
69-69: 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick winPass a readable email color into the sport support header subtitle The sport support description already contains email addresses in both dictionaries, and
parseFormattedText(content.description)renders them with#862633on the same#862633banner, making those links unreadable. Pass a lightemailColorhere, or letPageHeaderenforce a banner-safe link color.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/common/PageHeader.tsx` at line 69, The sport support header subtitle is rendering email links with a dark color that matches the banner background, making them unreadable. Update the PageHeader subtitle rendering path so the email/link color is light and readable on the `#862633` banner, either by passing a banner-safe `emailColor` into `parseFormattedText(content.description)` or by having `PageHeader` enforce a contrast-safe link color for this section.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/components/common/PageHeader.tsx`:
- Line 69: The sport support header subtitle is rendering email links with a
dark color that matches the banner background, making them unreadable. Update
the PageHeader subtitle rendering path so the email/link color is light and
readable on the `#862633` banner, either by passing a banner-safe `emailColor`
into `parseFormattedText(content.description)` or by having `PageHeader` enforce
a contrast-safe link color for this section.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 966c1854-4639-4188-b161-069e206f17d9
📒 Files selected for processing (3)
src/app/(app)/[lang]/sport/sportpalya-tamogatas/components/GymSupportContent.tsxsrc/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsxsrc/components/common/PageHeader.tsx
…for improved subtitle handling
Summary by CodeRabbit
New Features
UI Improvements
Bug Fixes