Skip to content

feat: implement redesigned Gym Support Content and update PageHeader …#172

Open
DankaMarci wants to merge 1 commit into
mainfrom
132-implement-redesigned-sports-field-support-sportpálya-támogatás-page

Hidden character warning

The head ref may contain hidden characters: "132-implement-redesigned-sports-field-support-sportp\u00e1lya-t\u00e1mogat\u00e1s-page"
Open

feat: implement redesigned Gym Support Content and update PageHeader …#172
DankaMarci wants to merge 1 commit into
mainfrom
132-implement-redesigned-sports-field-support-sportpálya-támogatás-page

Conversation

@DankaMarci

@DankaMarci DankaMarci commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

…for improved subtitle handling

Summary by CodeRabbit

  • New Features

    • The sport support page now shows a formatted subtitle in the header and uses richer text rendering for page content.
  • UI Improvements

    • Simplified the page layout and visual styling for the support content sections.
    • Updated section presentation, spacing, and callout styling for a cleaner look.
  • Bug Fixes

    • Adjusted header text handling so non-string content can display correctly.

@DankaMarci DankaMarci requested a review from peterlipt July 3, 2026 14:12
@DankaMarci DankaMarci self-assigned this Jul 3, 2026
@DankaMarci DankaMarci linked an issue Jul 3, 2026 that may be closed by this pull request
4 tasks
@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ehk Ready Ready Preview, Comment Jul 3, 2026 2:15pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

GymSupportContent.tsx is refactored to use new helper components (SectionCard, Paragraph, TextList, NoticeBox) for rendering sections, removing the description intro. PageHeaderProps now accepts React.ReactNode for subtitle/description. The sportpalya-tamogatas page passes a parsed subtitle and content variable to its components.

Changes

Sportpálya támogatás page redesign

Layer / File(s) Summary
PageHeader prop type widening
src/components/common/PageHeader.tsx
subtitle and description props widened from string to React.ReactNode, with description retained as a subtitle fallback.
Section rendering helpers
src/app/(app)/[lang]/sport/sportpalya-tamogatas/components/GymSupportContent.tsx
New SectionCard, Paragraph, TextList, and NoticeBox helper components standardize section framing, list rendering, and callout styling.
Content render restructuring
src/app/(app)/[lang]/sport/sportpalya-tamogatas/components/GymSupportContent.tsx
SportpalyaTamogatasContent output is rewritten to remove the description intro section and reuse the new helpers for application, period, condition, selection, result, and footer sections.
Page wiring for subtitle and content
src/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsx
Page assigns dictionary content to a content variable, parses content.description via parseFormattedText for the PageHeader subtitle, updates container/layout classes, and passes content to GymSupportContent.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related issues

Suggested reviewers: peterlipt

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main changes: redesigned Gym Support Content and PageHeader subtitle handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 132-implement-redesigned-sports-field-support-sportpálya-támogatás-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/components/common/PageHeader.tsx (1)

69-69: 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

Pass a readable email color into the sport support header subtitle The sport support description already contains email addresses in both dictionaries, and parseFormattedText(content.description) renders them with #862633 on the same #862633 banner, making those links unreadable. Pass a light emailColor here, or let PageHeader enforce a banner-safe link color.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/common/PageHeader.tsx` at line 69, The sport support header
subtitle is rendering email links with a dark color that matches the banner
background, making them unreadable. Update the PageHeader subtitle rendering
path so the email/link color is light and readable on the `#862633` banner,
either by passing a banner-safe `emailColor` into
`parseFormattedText(content.description)` or by having `PageHeader` enforce a
contrast-safe link color for this section.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/components/common/PageHeader.tsx`:
- Line 69: The sport support header subtitle is rendering email links with a
dark color that matches the banner background, making them unreadable. Update
the PageHeader subtitle rendering path so the email/link color is light and
readable on the `#862633` banner, either by passing a banner-safe `emailColor`
into `parseFormattedText(content.description)` or by having `PageHeader` enforce
a contrast-safe link color for this section.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 966c1854-4639-4188-b161-069e206f17d9

📥 Commits

Reviewing files that changed from the base of the PR and between 2cbebd5 and 5cf589f.

📒 Files selected for processing (3)
  • src/app/(app)/[lang]/sport/sportpalya-tamogatas/components/GymSupportContent.tsx
  • src/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsx
  • src/components/common/PageHeader.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Redesigned Sports Field Support (Sportpálya támogatás) Page

1 participant