fix(checkpoint): replay migrated delta writes through a plain seed#7957
Open
Christian Bromann (christian-bromann) wants to merge 2 commits into
Open
fix(checkpoint): replay migrated delta writes through a plain seed#7957Christian Bromann (christian-bromann) wants to merge 2 commits into
Christian Bromann (christian-bromann) wants to merge 2 commits into
Conversation
InMemorySaver.get_delta_channel_history skipped on-path writes when the terminating ancestor's blob was a plain (pre-delta migration) value instead of a _DeltaSnapshot, dropping post-migration writes on reload. Collect writes regardless of seed type, matching the base implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemorySaver.get_delta_channel_historydropping writes stored under a migration-boundary checkpoint. A plain (pre-delta) blob is the settled value AT that ancestor, so its pending writes produce the child and must be replayed on top of the seed — the guard that skipped writes for non-_DeltaSnapshotseeds made post-migration writes disappear on reload while remaining visible in the live invoke result._DeltaSnapshotlazy import) so the optimized override matches theBaseCheckpointSaverreference path.test_post_migration_write_survives_reload_through_plain_seedandtest_post_migration_reload_base_matches_optimized_override.