feat: prepare esm only#4550
Merged
Merged
Conversation
lovell
approved these changes
Jun 19, 2026
lovell
left a comment
lovell
left a comment
Owner
There was a problem hiding this comment.
Thank you very much for doing this, the font-related tests on Windows have been a bit flaky for a while due to font discovery problems (timeouts, wrong font selected etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4542 I had to do several things unrelated to the ESM migration:
In order to make reviewing said PR easier, I extracted these changes here to keep the other really focused.
I ran tests on Ubuntu and they worked