DM-43139: Refactor FileChannelShared to reduce mutex lock #851
Open
jgates108 wants to merge 4 commits into
Open
DM-43139: Refactor FileChannelShared to reduce mutex lock #851jgates108 wants to merge 4 commits into
jgates108 wants to merge 4 commits into
Conversation
jgates108
force-pushed
the
tickets/DM-43139
branch
from
f64e22c to
a45a91a
Compare
fritzm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only thing I'm concerned about here is that moving the mutex may result in more contention within mariadb as it can be required to hand out more results concurrently. Testing shows about a 20% improvement in dealing with tests/q7688979.1.4k.chunks.sql, but this may not be a great test case. At least moving some of the member variables to local makes it easier to relocate the mutex.