Add default CIF list to GSAS II tab in EngDiffUI#41709
Draft
andy-bridger wants to merge 5 commits into
Draft
Conversation
github-actions
Bot
added
the
Has Conflicts
Contributor
|
👋 Hi, @andy-bridger, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
# Conflicts: # qt/python/mantidqtinterfaces/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/model.py # qt/python/mantidqtinterfaces/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/presenter.py # qt/python/mantidqtinterfaces/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/view.py
andy-bridger
force-pushed
the
add-cif-defaults-to-eng-diff
branch
from
July 8, 2026 11:31
cbbc820 to
e534fde
Compare
github-actions
Bot
removed
the
Has Conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
A collection of cif files are pre-packaged within the engineering code, but it is a bit onerous to go and find them. This PR adds a drop down menu to the GSAS-II tab to provide quick access to these files along with a
Customoption at the end of the list which recovers the previous behaviour of supplying file paths.I also had to tweak the UI to try and make it a bit easier to visually parse after the new combo box was added (the finder widget widths have a mind of their own, but I think they should be the same width on linux for both the new one and old one)
Old:
New:
Closes #41654
To test:
Try running GSAS-II instructions on Ada and check expected behaviour
(I will make a mantid-test build on conda once the CI passes)
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: