Fix blank error message when using Serial on Firefox

[Hunter275]

Description

Fix for #1253 removes blank error box now that Firefox does support Serial

Related Issues

#1253

Changes Made

• Added check to return null if the tab id is "serial" and the unsupported array does not include "Web Serial"
• Added check to return null if the tab id is "bluetooth" and the unsupported array does not include "Web Bluetooth"

Testing Done

Tested on Firefox on macOS 15.6, will test on Windows tomorrow

Screenshots (if applicable)

Checklist

• Code follows project style guidelines
• Documentation has been updated or added
• Tests have been added or updated
• All i18n translation labels have been added (read
  CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

Summary by CodeRabbit

• Bug Fixes
  • Improved connection dialog messaging so feature warnings are shown only when they apply to the currently selected connection tab and the required security context.
  • Reduced unnecessary “missing feature” notices for unrelated connection options, making the dialog clearer and less cluttered.

[vercel]

@Hunter275 is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ddd6fca6-e9e4-4940-9743-ad5ec7055792

📥 Commits

Reviewing files that changed from the base of the PR and between bdaa313 and 75cca10.

📒 Files selected for processing (1)

• apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx

---

📝 Walkthrough

Walkthrough

FeatureErrorMessage now returns null when neither the active tab’s required feature nor Secure Context is missing, while continuing to render applicable feature warnings.

Changes

Feature error message filtering

Layer / File(s)	Summary
Filter feature error rendering apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx	Added an early return so FeatureErrorMessage renders only when the active tab’s required feature or Secure Context is missing.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit checks the warning screen,
Keeps only messages that are seen,
Secure context or tab in need,
All other notices skip and speed,
Hop, hop, tidy UI! 🐇✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely matches the main change: fixing the blank Serial error message on Firefox.
Description check	✅ Passed	The description follows the template and includes the problem, related issue, key changes, testing, and checklist.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR adjusts the Add Connection dialog’s feature-warning banner so Firefox users selecting Serial no longer see an empty red warning box when only unrelated features (e.g., Web Bluetooth) are unsupported.

Changes:

• Suppresses the feature warning banner on the Serial tab unless “Web Serial” is actually missing.
• Suppresses the feature warning banner on the Bluetooth tab unless “Web Bluetooth” is actually missing.

[danditomaso]

@Hunter275

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
web-test	Ready	Preview, Comment	Jul 10, 2026 5:23am