Skip to content

fix(parallel): add maxsplit=1 to prevent ValueError on values containing '=' #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devteamaegis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(parallel): add maxsplit=1 to prevent ValueError on values containing '=' #4175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/promptflow-parallel/promptflow/parallel/_config/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def _parse_prefixed_args(args: List[str], prefix: str) -> Dict[str, str]:
for _, arg in enumerate(args):
if arg.startswith(prefix):
if "=" in arg:
arg_name, arg_value = arg.split("=")
arg_name, arg_value = arg.split("=", 1)
if len(arg_name) > len(prefix):
parsed[arg_name[len(prefix) :]] = arg_value
elif pre_arg_name is None:
Expand Down
8 changes: 7 additions & 1 deletion src/promptflow-parallel/tests/parallel/unittests/_config/test_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# ---------------------------------------------------------
from pathlib import Path

from promptflow.parallel._config.parser import parse
from promptflow.parallel._config.parser import _parse_prefixed_args, parse


def test_parse_correct_type():
Expand Down Expand Up @@ -51,3 +51,9 @@ def test_parse_correct_type():
assert config.debug_output_dir == Path("/test_debug")
assert config.logging_level == "INFO"
assert not config.is_debug_enabled


def test_parse_prefixed_args_value_with_equals():
# Values containing '=' (e.g. base64 padding) must not crash with ValueError.
result = _parse_prefixed_args(["--pf_input_token=SGVsbG8gV29ybGQ="], "--pf_input_")
assert result == {"token": "SGVsbG8gV29ybGQ="}
Loading