Do not print updates to the public variables. Fixes #88#89
Merged
Conversation
xmacex
changed the title
Member
|
i believe this is correct--- i admit to never using public vars myself--- pinging @trentgill for confirmation. happy to release a new version upon fix |
Member
|
aha, any chance you saw the only other open PR? |
Contributor
Author
|
I did saw it exists, but didn't look closer at it. You are corrent, I see now that it addresses this same thing, and more. Thanks for pointing that out. Would merging PR, or cherrypicking the bits which filter events in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change so simple I must be misunderstanding something, and/or placing this in the wrong place. As I understand, the updates are still coming through and doing their thing, just that they aren't printed (
DruidRepl.output) into druid for the user to see.