Fix a couple of test hangs when running sandboxed#808
Open
jcristau wants to merge 2 commits into
Open
Conversation
Add a mock to avoid populate_projects hitting github when running tests, which adds flakyness, and breaks when running in a sandbox.
MagicMock().pid isn't a real int, so -process.pid resolved to 1 via MagicMock's default __index__(), causing these tests to issue real os.kill(1, SIGTERM/SIGKILL) calls instead of exercising the mocked process. Also drops a dead process.terminate.side_effect setup in test_stop_handle_process_lookup_error. stop() used to call self.process.terminate() in addition to os.kill(), but that call was removed in 046ca77 (2019-01-31) without updating this test, so that side_effect has had no effect (and the os.kill(1, ...) bug has been latent) ever since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some mocks to avoid hitting the network, and fix the TaskProcess tests to avoid killing pid 1.