Minor fixes for ContentActionApproveInitialDecision.txt#25062
Conversation
eviljeff
requested review from
a team and
nothingrandom
and removed request for
a team
|
|
||
| {% if has_attachment %} | ||
| An attachment was provided. {% if dev_url %}To respond or view the file, visit {{ dev_url }}.{% endif %} | ||
|
|
||
| {% endif %} | ||
| Thank you. |
There was a problem hiding this comment.
An alternative - possibly better - place to fix this is where we're saying "Thank you!" as a comment (I've not looked for it)
There was a problem hiding this comment.
I've considered that. However, in addition to "Thank you!" in the autoapproval comment, our default manual review comment is also "Thank you for your contribution." (here). So I thought it was better to remove "Thank you." here, given that it is supposed to be supplied with manual_reasoning_text
There was a problem hiding this comment.
we do have the "thank you" in the couple of places where there is a constant value for manual_reasoning_text, but it can also be any value provided by the reviewer.
There was a problem hiding this comment.
so this nails down to the question of whether reviewers are supposed to say "thank you", which I can't answer
denyshon
force-pushed
the
patch-1
branch
2 times, most recently
from
2ab3292 to
6b3614d
Compare
3 participants
Fixes mozilla/addons#16252