Remove French-only PDF fallback pages#17263
Conversation
`complete-pdf` and `free-pdf-editor` are now 301'd to `www.firefox.com`, so their routes and FR-only templates were dead code. Also drops the unused `fr` branch from `firefox_features_pdf`. Follow-up to PR #16867 and issue #16395.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17263 +/- ##
==========================================
+ Coverage 82.84% 82.88% +0.04%
==========================================
Files 178 178
Lines 9414 9409 -5
==========================================
Hits 7799 7799
+ Misses 1615 1610 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stevejalim
left a comment
There was a problem hiding this comment.
R+
you could merge this as-is and do your follow-up separately, or bundle it all into here - I am easy either way.
In terms of the link to FXC, I think your in-markup solution <a href="{{ settings.FXC_BASE_URL }}/features/pdf-editor/?redirect_source=mozilla-org" ...> will do the job - it's obvious about what it's doing 👍
|
@stephaniehobson mentioned in Slack that pages like |
Summary
complete-pdfandfree-pdf-editorare now 301'd towww.firefox.com, so their routes and FR-only templates were dead code. Also drops the unusedfrbranch fromfirefox_features_pdf.Follow-up cleanup for issue #16395, on top of PR #16867.
Follow-up
Six templates (
nothing-personal,features/index, and the fourcompare/*pages) still link to the PDF editor viaurl('firefox.features.pdf-editor'), which is the only reason that route, view, andpdf-editor.htmlare kept around. If we hardcode those links straight to www.firefox.com, we could delete the route and template entirely, but it reaches into pages outside the PDF scope so it is a separate follow-up. Any suggestions?Maybe
<a href="{{ settings.FXC_BASE_URL }}/features/pdf-editor/?redirect_source=mozilla-org" ...>or something different?Current approach is in line 194
bedrock/bedrock/firefox/templates/firefox/nothing-personal/index.html
Lines 189 to 195 in e755480