Fix false enable of highlights when opening the editor menu#21535
Fix false enable of highlights when opening the editor menu#21535LoukasPap wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21535 +/- ##
==========================================
+ Coverage 89.83% 89.85% +0.01%
==========================================
Files 263 263
Lines 66802 66806 +4
==========================================
+ Hits 60014 60027 +13
+ Misses 6788 6779 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@calixteman I applied the changes discussed |
| layer.updateMode(mode); | ||
| } | ||
|
|
||
| const highlightShowAllState = this.#showAllStates?.get( |
There was a problem hiding this comment.
I don't think it's enough in general.
With tracemonkey.pdf, you can
- highlight on the 1st page
- scroll and highlight on the last one
- scroll back to the first
- hide the highlights
- turn off the highlight mode
- turn it on
- scroll to the last page.
There was a problem hiding this comment.
Thanks for drawing my attention to these cases! I'll check them out.
a7645cc to
9ab860e
Compare
9ab860e to
4d5fca8
Compare
| for (const editor of this.#allEditorsIterator) { | ||
| editor.enableEditing(); | ||
| editor.show(true); | ||
| editor.show(); |
There was a problem hiding this comment.
@calixteman When a page layer was turned back on, every editor was shown again and so did the highlights.
Fixes #21498
The fix ensures that the "Show all" toggle button remains consistent across updates in editor mode and it reflects the correct highlight state (even if we highlight from floating toolbar).
The two integration tests cover the following cases:
Test 1
Test 2