This repository was archived by the owner on Jan 15, 2023. It is now read-only.
Merge latest code from suleman1971#13
Open
sonec wants to merge 12 commits into
Open
Conversation
Fix typo in hot keys list: replace “Toogle” with “Toggle”
Owner
|
Oh wow! Thanks for doing this, it’s hugely appreciated. Version bump seems entirely appropriate. Translated comments make this much harder to manage, but I think it hugely adds understanding to the codebase. Wonder if there’s a better way to manage it? I’ll look at this in the upcoming week. |
Owner
|
PS: I don’t know what to do about author/contact details either :) |
Owner
|
I realise this is still open, and I haven’t forgotten about it! |
Owner
|
@sonec is there any chance you want to take over this repo for me? I don’t even do distributed computing anymore to be honest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mpentler
I just noticed you raise issue #12 so I though I'd give it a try.
It includes all changes as of Jan 4, 2021. It looks to be that many of the conflicts were due to lines with translated comments that were subsequently moved.
It compiles on my local machine (gcc version 9.3.0) and it seems to run fine. I haven't tried the new features that were introduced though.
I've also re-added the debian files as there were changes in them too, I've kept the original author's details in the contact details. Not sure whose details to use in all honesty.
I've also incremented the version number to 1.0.3 hope that's okay.