Skip to content
This repository was archived by the owner on Jan 15, 2023. It is now read-only.

Merge latest code from suleman1971#13

Open
sonec wants to merge 12 commits into
mpentler:masterfrom
far2asian:12_merge_parent
Open

Merge latest code from suleman1971#13
sonec wants to merge 12 commits into
mpentler:masterfrom
far2asian:12_merge_parent

Conversation

@sonec

@sonec sonec commented Oct 30, 2021

Copy link
Copy Markdown

Hi @mpentler

I just noticed you raise issue #12 so I though I'd give it a try.

It includes all changes as of Jan 4, 2021. It looks to be that many of the conflicts were due to lines with translated comments that were subsequently moved.

It compiles on my local machine (gcc version 9.3.0) and it seems to run fine. I haven't tried the new features that were introduced though.

I've also re-added the debian files as there were changes in them too, I've kept the original author's details in the contact details. Not sure whose details to use in all honesty.

I've also incremented the version number to 1.0.3 hope that's okay.

@mpentler

Copy link
Copy Markdown
Owner

Oh wow! Thanks for doing this, it’s hugely appreciated. Version bump seems entirely appropriate.

Translated comments make this much harder to manage, but I think it hugely adds understanding to the codebase. Wonder if there’s a better way to manage it?

I’ll look at this in the upcoming week.

@mpentler

Copy link
Copy Markdown
Owner

PS: I don’t know what to do about author/contact details either :)

@mpentler

Copy link
Copy Markdown
Owner

I realise this is still open, and I haven’t forgotten about it!

@mpentler

Copy link
Copy Markdown
Owner

@sonec is there any chance you want to take over this repo for me? I don’t even do distributed computing anymore to be honest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants