Use contract start date, not tender start date in templates#56
Open
stevenday wants to merge 1 commit into
Open
Use contract start date, not tender start date in templates#56stevenday wants to merge 1 commit into
stevenday wants to merge 1 commit into
Conversation
It's already labelled as such in the UI, but we weren't pulling the right field from the OCDS json to be able to show a contract start date, instead showing the tender's start date, which can be confusing. This adds a new field to the model to get the right data from the OCDS JSON and then shows that instead. Note that this changes the Postgres view, so we need to run `python manage.py sync_pgviews --force` to regenerate them, but this is contained within script/migrate, so I presume would be run on normal deployment anyway.
Author
|
We've been doing some work at Open Ownership to localise the Bluetail prototype for Indonesia and Mexico and we noticed this little bug along the way, so I thought I'd PR it. I'll also share some of the translation stuff we've been doing in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already labelled as such in the UI, but we weren't pulling the
right field from the OCDS json to be able to show a contract start date,
instead showing the tender's start date, which can be confusing.
This adds a new field to the model to get the right data from the OCDS
JSON and then shows that instead. I've also added the corresponding
end date field for completeness.
Note that this changes the Postgres view, so we need to run
python manage.py sync_pgviews --forceto regenerate them, but this iscontained within script/migrate, so I presume would be run on normal
deployment anyway.