PNPM 11 instead of NPM#2708
Open
pxp9 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
it seems there is a flacky test breaking the PR CI. |
joshk
reviewed
Jun 1, 2026
joshk
left a comment
joshk
left a comment
Collaborator
There was a problem hiding this comment.
I'll need to review this later in the week as I want to test it locally and confirm a few questions I have around pnpm setup.
joshk
requested changes
Jun 9, 2026
joshk
left a comment
joshk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR
Why was the default package.lock not removed?
I also noticed that the Dockerfile hasn't been updated to install and use pnpm.
| defp aliases() do | ||
| [ | ||
| "assets.install": ["cmd pnpm install --dir assets"], | ||
| "assets.build": ["esbuild default", "tailwind default"], |
Collaborator
There was a problem hiding this comment.
I think these are the correct changes:
"assets.setup": ["tailwind.install --if-missing", "esbuild.install --if-missing", "cmd pnpm install --dir assets"],
"assets.build": ["compile", "tailwind default", "esbuild default"],
"assets.deploy": ["tailwind default --minify", "esbuild default --minify", "phx.digest"],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces NPM usage with PNPM 11 usage because PNPM is secure by default to supply chain attacks which recently happened in the JS ecosystem.