Write firmware uploads directly to the temp dir#2791
Open
mcrumm wants to merge 1 commit into
Open
Conversation
The Firmware LiveView now utilizes the Phoenix.LiveView.UploadWriter behaviour to write directly to a durable temp file. Once the upload is complete, the FirmwareUploadWriter passes ownership of the temp file to the LiveView process so that it survives after the writer process exits.
Collaborator
|
Hey @mcrumm This is a smart approach, I feel silly for not thinking of this. The double write always annoyed me. Since Please do continue with this magic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses the
Phoenix.LiveView.UploadWriterbehaviour to avoid double-writing to temp when uploading firmware.Note that there is an opportunity to better handle errors from the writer process, but I wanted to get feedback on change before taking it any further. Thanks!