Improve keyboard behavior in the advanced device search#2830
Open
lawik wants to merge 1 commit into
Open
Conversation
Enter and Tab now complete suggestions the way you'd expect from a command palette, instead of requiring arrow-key navigation first: - Tab accepts the highlighted suggestion, or the first one - Enter does the same while mid-word (a non-empty prefix), so typing "hea" + Enter gives "health" rather than running a failed search - Enter on a structurally incomplete query (mid-term, dangling and/or, unclosed paren) advances to the next slot and shows its suggestions - e.g. out of a finished "like" operator and into the value - instead of submitting a query the server is guaranteed to reject - Enter on a trailing unterminated string closes the quote and submits - A finished query still submits with Enter even while the "and"/"or" hints are showing; Escape-dismissed suggestions are never accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter and Tab now complete suggestions the way you'd expect from a command palette, instead of requiring arrow-key navigation first: