Skip to content

Use Spoofchecker::isSuspicious in phishing link host analysis #13090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −2
Draft

Use Spoofchecker::isSuspicious in phishing link host analysis #13090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5087990
Initial plan
Copilot Jun 16, 2026
b274f01
fix(phishing): flag suspicious spoofed link hosts
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lib/Service/PhishingDetection/LinkCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,20 @@ private function parse(string $url): string {
return strtolower($url);
}

protected function isSuspiciousHost(?string $host): bool {
if ($host === null || $host === '' || !class_exists('\Spoofchecker')) {
return false;
}

$spoofchecker = new \Spoofchecker();

try {
return $spoofchecker->isSuspicious($host);
} catch (\Throwable) {
return false;
}
}

public function run(string $htmlMessage) : PhishingDetectionResult {
$results = [];
$zippedArray = [];
Expand Down Expand Up @@ -80,7 +94,9 @@ public function run(string $htmlMessage) : PhishingDetectionResult {
$un = new Normalizer($zipped['href']);
$url = $un->normalize();
if ($this->textLooksLikeALink($zipped['linkText'])) {
if (parse_url($this->parse($url), PHP_URL_HOST) !== parse_url($this->parse($zipped['linkText']), PHP_URL_HOST)) {
$hrefHost = parse_url($this->parse($url), PHP_URL_HOST);
$linkTextHost = parse_url($this->parse($zipped['linkText']), PHP_URL_HOST);
if ($hrefHost !== $linkTextHost || $this->isSuspiciousHost($hrefHost) || $this->isSuspiciousHost($linkTextHost)) {
$results[] = [
'href' => $url,
'linkText' => $zipped['linkText'],
Expand All @@ -103,7 +119,7 @@ private function generateResult(array $results): PhishingDetectionResult {
return new PhishingDetectionResult(
PhishingDetectionResult::LINK_CHECK,
true,
$this->l10n->t('Some addresses in this message are not matching the link text'),
$this->l10n->t('Some addresses in this message are suspicious or do not match the link text'),
$results
);
}
Expand Down
14 changes: 14 additions & 0 deletions tests/Unit/Service/PhishingDetection/LinkCheckTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,20 @@ public function testMultipleLinksOnePhishingReturnsWarning(): void {
$this->assertTrue($result->isPhishing());
}

public function testLinkWithSuspiciousMatchingDomainReturnsWarning(): void {
$check = new class($this->l10n) extends LinkCheck {
protected function isSuspiciousHost(?string $host): bool {
return $host === 'xn--pple-43d.com';
}
};

$html = '<html><body><a href="https://xn--pple-43d.com">https://xn--pple-43d.com</a></body></html>';

$result = $check->run($html);

$this->assertTrue($result->isPhishing());
}

public function testLinkWithBracketsReturnsSafe(): void {
$html = '<html><body><a href="https://example.com">(https://example.com)</a></body></html>';

Expand Down