fix(settings): respect the writing mode in the signature editor#13141
Open
joeldj-nl wants to merge 1 commit into
Open
fix(settings): respect the writing mode in the signature editor#13141joeldj-nl wants to merge 1 commit into
joeldj-nl wants to merge 1 commit into
Conversation
The signature editor was always rich text, so a signature image was mangled into raw HTML when the account's writing mode was plain text. - Drive the signature editor's mode from the account's writing mode and re-encode the signature to the active format (HTML or plain text). - Warn before switching from rich text to plain text, since that drops formatting, inline images and links — including those in the signature. Fixes nextcloud#7142 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Joël de Jager <contact@joeldejager.nl>
joeldj-nl
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
1 task
Member
|
I wasn't familiar with #7142 and I'm a bit unsure about the approach. I checked Gmail as reference and they just have the rich signature editor like we currently have. The only thing they do better is when you actually compose an email the writing mode dictates if HTML is stripped to plain text for the signature. |
ChristophWurst
added
bug
3. to review
feature:editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7142
Summary
The signature editor always used rich text mode, even when the account was configured to compose messages as plain text. As a result, signatures containing images or other HTML content could be exposed as raw HTML after switching to plain text mode.
Changes
recording-writing-mode.mp4
Assisted-by: Claude:claude-opus-4-8