Skip to content

fix(security): 2 improvements across 2 files #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(security): 2 improvements across 2 files #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bc0525
fix(security): 2 improvements across 2 files
tomaioo Apr 25, 2026
d31fa3b
fix(security): 2 improvements across 2 files
tomaioo Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/app/services/encryptservice.js
View file
Open in desktop

@binsky08 binsky08 Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint.
I'll keep an eye on this. Just changing the numbers here would most likely break the app right now. Not the encryption itself, but the app logic. I'll figure out how the other project depending apps and libs are handling this right now before touching anything here.

Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
// AngularJS will instantiate a singleton by calling "new" on this function
var encryption_config = {
adata: "",
iter: 1000,
iter: 100000,
ks: 256,
mode: 'ccm',
ts: 64
ts: 128
};

return {
Expand Down
8 changes: 7 additions & 1 deletion js/app/services/settingsservice.js
View file
Open in desktop

@binsky08 binsky08 Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, setting a default vault with optional auto login is a "feature" and requires the vault password to be stored in defaultVaultPass. Not sure who would use that, but it's basically intended behaviour.
I am sure your changes here would break that.

Image

So please explain the reason for the changes here, or remove them.

Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
});

var cookie = localStorageService.get('settings');
if (cookie && cookie.defaultVaultPass !== undefined) {
delete cookie.defaultVaultPass;
}
settings = angular.merge(settings, cookie);
return {
getSettings: function () {
Expand All @@ -55,8 +58,11 @@
return settings[name];
},
setSetting: function (name, value) {
var storedSettings;
settings[name] = value;
localStorageService.set('settings', settings);
storedSettings = angular.copy(settings);
delete storedSettings.defaultVaultPass;
localStorageService.set('settings', storedSettings);
},
isEnabled: function (name) {
return settings[name] === 1 || settings[name] === '1';
Expand Down