Skip to content

Update bakta modules to 1.120#12041

Merged
jfy133 merged 27 commits into
nf-core:masterfrom
jfy133:update-bakta
Jun 22, 2026
Merged

Update bakta modules to 1.120#12041
jfy133 merged 27 commits into
nf-core:masterfrom
jfy133:update-bakta

Conversation

@jfy133

@jfy133 jfy133 commented Jun 18, 2026

Copy link
Copy Markdown
Member

Also switched to Seqera containers due to due issues with conda dependecy resolution

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Comment thread modules/nf-core/bakta/bakta/environment.yml
@jfy133

jfy133 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Thanks @mashehu !

@jfy133 jfy133 enabled auto-merge June 18, 2026 13:07
@jfy133

jfy133 commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

AHHH FAILING TESTS :shakesfist:

@jfy133 jfy133 added this pull request to the merge queue Jun 18, 2026
@jfy133 jfy133 removed this pull request from the merge queue due to a manual request Jun 18, 2026
@jfy133 jfy133 added this pull request to the merge queue Jun 22, 2026
Merged via the queue into nf-core:master with commit 81fe5e6 Jun 22, 2026
30 checks passed
@jfy133 jfy133 deleted the update-bakta branch June 22, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants