Fix Vulkan example hang - #9497
Open
Nemirtingas wants to merge 1 commit into
Open
Conversation
When vkQueuePresentKHR or vkAcquireNextImageKHR return VK_SUBOPTIMAL_KHR, FramePresent will not be called because of
if (g_SwapChainRebuild)
return;
Making vkQueuePresentKHR never called and never releasing the current frame, hanging the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When vkQueuePresentKHR or vkAcquireNextImageKHR return VK_SUBOPTIMAL_KHR, FramePresent will not be called because of
https://github.com/ocornut/imgui/blob/v1.92.9/examples/example_win32_vulkan/main.cpp#L321-L322
Making vkQueuePresentKHR never called and never releasing the current frame, hanging the app because g_SwapChainRebuild is currently only released in the WM_SIZE message https://github.com/ocornut/imgui/blob/v1.92.9/examples/example_win32_vulkan/main.cpp#L546-L560