Check if TARGET_OS_OSX is defined before evaluating its value - #9498
Open
nilFinx wants to merge 1 commit into
Open
Check if TARGET_OS_OSX is defined before evaluating its value#9498nilFinx wants to merge 1 commit into
nilFinx wants to merge 1 commit into
Conversation
Solves a case where __APPLE__ is defined, but TARGET_OS_OSX isn't, causing a compile error. Happens on my OS X 10.9 setup with MacPorts Clang 16 instead of the Xcode Clang 6.
Owner
|
How could it be undefined at the top of imgui.cpp has: // [Apple] OS specific includes
#if defined(__APPLE__)
#include <TargetConditionals.h>
#endifCan you clarify? I am not confident having random tests without validating the root cause. Could you investigate why MacPorts Clang 16 doesn't have those inside TargetConditionals.h ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves a case where APPLE is defined, but TARGET_OS_OSX isn't, causing a compile error. Happens on my OS X 10.9 setup with MacPorts Clang 16 instead of the Xcode Clang 6.
Compile log before fix: