Skip to content

[lint] Remove workaround for previous gaps in AST walking#631

Merged
turbolent merged 2 commits into
masterfrom
bastian/lint-fix-unused-import-analyzer
Jun 30, 2026
Merged

[lint] Remove workaround for previous gaps in AST walking#631
turbolent merged 2 commits into
masterfrom
bastian/lint-fix-unused-import-analyzer

Conversation

@turbolent

@turbolent turbolent commented Apr 16, 2026

Copy link
Copy Markdown
Member

Closes onflow/cadence#4470

Description

onflow/cadence#4471 fixed the AST walking, so the workaround in the unused import analyzer is no longer necessary.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! 🧹

@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Apr 17, 2026
@turbolent turbolent changed the title [DO NOT MERGE] [lint] Remove workaround for previous gaps in AST walking [lint] Remove workaround for previous gaps in AST walking Jun 30, 2026
@turbolent turbolent enabled auto-merge June 30, 2026 19:37
@turbolent turbolent merged commit 6f99918 into master Jun 30, 2026
10 checks passed
@turbolent turbolent deleted the bastian/lint-fix-unused-import-analyzer branch June 30, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve AST inspector to traverse all nested elements

2 participants