Copy only xml files as there is a 1MB limit for SHARED_DIR#81192
Copy only xml files as there is a 1MB limit for SHARED_DIR#81192FilipB wants to merge 2 commits into
Conversation
WalkthroughThe sail-operator e2e script now copies only ChangesSail-operator e2e artifact handoff
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FilipB The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh`:
- Around line 169-171: The artifact copy step only copies top-level XML files,
but has_junit_reports() detects junit*.xml and report.xml recursively under
ARTIFACT_DIR. Update the artifact sharing logic in
servicemesh_sail_operator_e2e_ocp_commands.sh so the copy for SHARED_DIR also
walks subdirectories and preserves all matching XML reports, not just files in
the root. Keep the existing XML-only constraint and align the copy behavior with
has_junit_reports() so nested reports are included.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a1846250-d116-4bcc-af24-1d14952debce
📒 Files selected for processing (1)
ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh
|
/pj-rehearse pull-ci-openshift-service-mesh-sail-operator-release-3.4-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.23-e2e-ocp |
|
@FilipB: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh (1)
171-172: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winQuote the directory variables in the
lscalls.These two expansions are unquoted, so shell word-splitting/globbing can mangle the diagnostic output if either path ever contains spaces or wildcard characters.
Suggested fix
- ls -alh ${ARTIFACT_DIR} - ls -alh ${SHARED_DIR} + ls -alh "${ARTIFACT_DIR}" + ls -alh "${SHARED_DIR}"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh` around lines 171 - 172, The diagnostic ls calls in the e2e-ocp command script use unquoted ARTIFACT_DIR and SHARED_DIR expansions, which can break on spaces or glob characters. Update the ls invocations in the relevant script section to quote those directory variables, keeping the existing commands and behavior otherwise unchanged. Reference the ls usage in the servicemesh-sail-operator-e2e-ocp command script so the fix is applied to both directory listings.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh`:
- Around line 171-172: The diagnostic ls calls in the e2e-ocp command script use
unquoted ARTIFACT_DIR and SHARED_DIR expansions, which can break on spaces or
glob characters. Update the ls invocations in the relevant script section to
quote those directory variables, keeping the existing commands and behavior
otherwise unchanged. Reference the ls usage in the
servicemesh-sail-operator-e2e-ocp command script so the fix is applied to both
directory listings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e9e07dec-dd69-4d62-8840-cd1cfd44c99b
📒 Files selected for processing (1)
ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh
|
@FilipB: |
|
/pj-rehearse pull-ci-openshift-service-mesh-sail-operator-release-3.4-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.23-e2e-ocp |
|
@FilipB: your |
|
/pj-rehearse pull-ci-openshift-service-mesh-sail-operator-release-3.4-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.23-e2e-ocp |
|
@FilipB: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-service-mesh-sail-operator-release-3.4-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.22-e2e-ocp pull-ci-openshift-service-mesh-sail-operator-main-ocp-4.23-e2e-ocp |
|
@FilipB: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@FilipB: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
This PR adjusts the OpenShift Service Mesh Sail Operator E2E OCP prow step to only copy XML test artifacts (e.g.,
*.xml) from the test pod’sARTIFACT_DIRintoSHARED_DIR. Practically, this reduces the amount of data shared to the next upload/report-portal step so the job stays within the 1MB upload size limit, while preserving the XML reports needed by downstream processing.In
ci-operator/step-registry/servicemesh/sail-operator/e2e-ocp/servicemesh-sail-operator-e2e-ocp-commands.sh, the “share artifacts” portion now performs the filtered XML copy and addsls -alhlistings forARTIFACT_DIRandSHARED_DIRaround that handoff.