Fixes bug 5362, use local initiator IP for BGP neighbor as update-source value

* Added validation - options are mutually exclusive
* FRR does not complain if given address is not on the host at the moment

Author: Marcin Matlag

net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditBGPNeighbor.xml

@@ -70,7 +70,7 @@
     <label>Local Initiater IP</label>
     <type>text</type>
     <advanced>true</advanced>
-    <help>Specify the local IP address (IPv4 or IPv6) used as the source to initiate BGP/BFD sessions and connections with the neighbor, including MD5 authentication. Takes precedence over Update-Source Interface when set.</help>
+    <help>Specify the local IP address (IPv4 or IPv6) used as the source to initiate BGP/BFD sessions, including MD5 authentication. Mutually exclusive with Update-Source Interface.</help>
     <grid_view>
       <visible>false</visible>
     </grid_view>
@@ -79,7 +79,7 @@
     <id>neighbor.updatesource</id>
     <label>Update-Source Interface</label>
     <type>dropdown</type>
-    <help>Interface (IPv4) where BGP sessions are sourced from, typically required when using loopback addresses.</help>
+    <help>Interface (IPv4) where BGP sessions are sourced from, typically required when using loopback addresses. Mutually exclusive with Local Initiator IP.</help>
     <grid_view>
       <visible>false</visible>
     </grid_view>

net/frr/src/opnsense/mvc/app/views/OPNsense/Quagga/bgp.volt

@@ -38,16 +38,6 @@ POSSIBILITY OF SUCH DAMAGE.
             }
         });
 
-        function checkNeighborSourceConflict() {
-            const $block = $('#help_block_neighbor\\.updatesource');
-            if ($('#neighbor\\.updatesource').val() && $('#neighbor\\.localip').val()) {
-                $block.text('{{ lang._("Update-Source Interface and Local Initiator IP are mutually exclusive.") }}');
-            } else {
-                $block.text('');
-            }
-        }
-        $(document).on('change', '#neighbor\\.updatesource, #neighbor\\.localip', checkNeighborSourceConflict);
-
         mapDataToFormUI({'frm_bgp_settings':"/api/quagga/bgp/get"}).done(function(data){
             formatTokenizersUI();
             $('.selectpicker').selectpicker('refresh');