fix: emit valid codex stop-hook cleanup output#1540
Open
zerone0x wants to merge 1 commit into
Open
Conversation
Fixes oraios#1533 Co-Authored-By: Claude <noreply@anthropic.com>
zerone0x
force-pushed
the
fix/codex-cleanup-stop-hook-json-1533
branch
from
5cc3dad to
fdd29b5
Compare
MischaPanch
requested changes
Jun 7, 2026
MischaPanch
left a comment
MischaPanch
left a comment
Member
There was a problem hiding this comment.
The issue describes the case "no session id sent" but this case should never occur. Does this actually happen with codex? If yes, none of our hooks would work for codex
| shutil.rmtree(self.session_persistence_dir, ignore_errors=True) | ||
| if self._session_id is not None: | ||
| shutil.rmtree(self.session_persistence_dir, ignore_errors=True) | ||
| if self._client == HookClient.CODEX: |
Member
There was a problem hiding this comment.
Is it a bad idea to always echo this?
|
|
||
|
|
||
| class SessionEndCleanupHook(Hook): | ||
| def __init__(self, client: HookClient): |
Member
There was a problem hiding this comment.
super init is missing. The hooks assume that session_id is always passed, is that not true for codex? Serena's hooks don't work without a session id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1533.
for codex cleanup hooks, this now always emits valid stop-hook json (
{"continue": true}) and treats a missing session id as a no-op instead of raising.