You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TestRustDiagnostics::test_file_diagnostics was intermittently failing because Rust diagnostics can arrive after the default wait window, producing an empty result (AssertionError: []). While it was first observed on windows-latest, the timing issue can occur on other platforms too. This change makes Rust diagnostics waiting more tolerant across platforms.
This is related to recent Rust LS diagnostics flow changes: diagnostics retrieval now relies on pull diagnostics first and then falls back to waiting for publishDiagnostics when pull results are empty, so delayed published diagnostics can miss the shorter default window.
Diagnostics timeout behavior (Rust Analyzer)
Override Rust Analyzer’s published-diagnostics wait timeout to use a longer floor on all platforms (>= 8s).
Regression coverage
Add focused timeout-policy coverage verifying the extended wait is used on both Windows and non-Windows paths.
CopilotAI
changed the title
[WIP] Fix failing GitHub Actions job Tests on windows-latest
Stabilize Rust diagnostics retrieval on Windows CI
Jun 9, 2026
@copilot the error appears in all platforms, not just windows. You should also explain how the error is related to recent changes to our rust LS support
@copilot the error appears in all platforms, not just windows. You should also explain how the error is related to recent changes to our rust LS support
Addressed in eaa93079.
I changed Rust Analyzer to use the extended published-diagnostics wait timeout on all platforms (not only Windows), and updated the timeout test to cover both Windows and Linux.
Why this is tied to recent Rust LS changes: after the recent diagnostics-flow updates in SolidLanguageServer (pull diagnostics first, then fallback to waiting for publishDiagnostics when pull returns no items), Rust can return an empty pull response and publish diagnostics slightly later. The previous default wait window was sometimes too short, which caused the intermittent empty diagnostics ([]) assertion failure.
CopilotAI
changed the title
Stabilize Rust diagnostics retrieval on Windows CI
Stabilize Rust diagnostics retrieval across CI platforms
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRustDiagnostics::test_file_diagnosticswas intermittently failing because Rust diagnostics can arrive after the default wait window, producing an empty result (AssertionError: []). While it was first observed onwindows-latest, the timing issue can occur on other platforms too. This change makes Rust diagnostics waiting more tolerant across platforms.This is related to recent Rust LS diagnostics flow changes: diagnostics retrieval now relies on pull diagnostics first and then falls back to waiting for
publishDiagnosticswhen pull results are empty, so delayed published diagnostics can miss the shorter default window.Diagnostics timeout behavior (Rust Analyzer)
>= 8s).Regression coverage