fix(iis): correct InstallModule32/64 CustomAction ID naming swap#3603
Open
fzipi wants to merge 1 commit into
Open
fix(iis): correct InstallModule32/64 CustomAction ID naming swap#3603fzipi wants to merge 1 commit into
fzipi wants to merge 1 commit into
Conversation
In the 64-bit installer (Win64=yes), the CustomAction IDs were swapped relative to what they actually install: "InstallModule32" installed the 64-bit module (System32, bitness64 precondition) and "InstallModule64" installed the 32-bit one (SysWOW64, bitness32 precondition). Not a functional bug: both actions run unconditionally on every install and are correctly gated by appcmd's own /preCondition bitness check rather than by the CustomAction ID, and the InstallExecuteSequence references already matched their (mis-)named actions consistently. But the naming makes the file misleading to maintain, and inconsistent with the already-correctly-named UninstallModule32/64 pair. Rename only, no logic/order change: swap the two CustomAction Ids and update the matching InstallExecuteSequence "Custom Action" references so each ID now matches its actual bitness, in the same relative order as before. Found while reviewing owasp-modsecurity#3491. Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
In
iis/installer.wxs, within the 64-bit installer path (Win64=yes), the twoInstallModule*CustomActionIDs were swapped relative to what they actually install:CustomAction Id="InstallModule32"installed the 64-bit module (System32,/preCondition:"bitness64")CustomAction Id="InstallModule64"installed the 32-bit module (SysWOW64,/preCondition:"bitness32")This swaps the two IDs (and updates the matching
InstallExecuteSequencereferences) so each ID now matches its actual bitness, in the exact same relative execution order as before.why
Not a functional bug: both actions run unconditionally on every install and are correctly gated by
appcmd's own/preConditionbitness check rather than by theCustomActionID, and the sequence references already matched their (mis-)named actions consistently. But the naming is misleading to anyone maintaining this file, and inconsistent with the already-correctly-namedUninstallModule32/UninstallModule64pair a few lines below, which don't have this swap.Rename only — no logic or ordering change. Verified
iis/installer.wxsis still well-formed XML (xmllint --noout) and re-checked every remainingInstallModule32/InstallModule64reference in the file for consistency after the rename.references
Found while reviewing #3491.
AI Disclosure
Found and fixed with the assistance of Claude Sonnet 5, based on a naming inconsistency I noticed while reviewing PR #3491. Verified by direct inspection of the diff and by checking XML well-formedness; no behavioral change intended or introduced.