Bump version to 26 - #498
Merged
Merged
Conversation
This should have been done for #497
Contributor
Author
|
Edit: done! |
jamesmunns
commented
Jul 10, 2026
| mod v25; | ||
| mod v26; | ||
|
|
||
| #[track_caller] |
Contributor
Author
There was a problem hiding this comment.
If you'd like, I can back this change out, but I think it's useful. It means we get errors like this:
thread 'versioning::v26::get_pmbus_status_error' panicked at gateway-messages/tests/versioning/v26.rs:121:9:
assertion `left == right` failed: incorrect serialization of PmbusStatus(UnknownRail)
left: [123, 0]
right: [39, 0]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
instead of:
thread 'versioning::v26::get_pmbus_status_error' panicked at gateway-messages/tests/versioning/mod.rs:48:5:
assertion `left == right` failed: incorrect serialization of PmbusStatus(UnknownRail)
left: [123, 0]
right: [39, 0]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
jgallagher
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should have been done for #497
CC #495, which will bump to v27