Skip to content

Bump version to 26 - #498

Merged
jamesmunns merged 2 commits into
mainfrom
james/bump-version-26
Jul 13, 2026
Merged

Bump version to 26#498
jamesmunns merged 2 commits into
mainfrom
james/bump-version-26

Conversation

@jamesmunns

Copy link
Copy Markdown
Contributor

This should have been done for #497

CC #495, which will bump to v27

This should have been done for #497
@jamesmunns
jamesmunns requested a review from jgallagher July 10, 2026 11:51
@jamesmunns

jamesmunns commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

I need to come back and cover PmbusStatusError (and SpError::PmbusStatus), PmbusStatusReadError is covered.

Edit: done!

mod v25;
mod v26;

#[track_caller]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like, I can back this change out, but I think it's useful. It means we get errors like this:

thread 'versioning::v26::get_pmbus_status_error' panicked at gateway-messages/tests/versioning/v26.rs:121:9:
assertion `left == right` failed: incorrect serialization of PmbusStatus(UnknownRail)
  left: [123, 0]
 right: [39, 0]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

instead of:

thread 'versioning::v26::get_pmbus_status_error' panicked at gateway-messages/tests/versioning/mod.rs:48:5:
assertion `left == right` failed: incorrect serialization of PmbusStatus(UnknownRail)
  left: [123, 0]
 right: [39, 0]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@jamesmunns
jamesmunns merged commit af9d3c9 into main Jul 13, 2026
12 checks passed
@jamesmunns
jamesmunns deleted the james/bump-version-26 branch July 13, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants