[test-utils] use a TCP proxy to keep dpd port bound across restarts#10726
Merged
sunshowers merged 2 commits intoJul 2, 2026
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jul 2, 2026
|
|
||
| **Example commits:** | ||
|
|
||
| * https://github.com/oxidecomputer/omicron/commit/AAAAA[`AAAAA`] introduces the TCP proxy. |
Contributor
There was a problem hiding this comment.
Do you want to link to this PR to avoid having to update it after it lands?
Contributor
Author
There was a problem hiding this comment.
I've generally been linking to commit hashes so that automated tools like Claude can just git/jj show them and not have to reach out to the network.
sunshowers
deleted the
sunshowers/spr/test-utils-use-a-tcp-proxy-to-keep-dpd-port-bound-across-restarts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10697 we saw occasional failures where other tests would end up binding a port. Avoid that by using a TCP proxy in the middle, which keeps the port bound throughout.
Also do some other cleanups like using consuming methods and combining the running and stopped dendrite maps.
This should fix #10697 but I'll leave that open until we don't see this test be flaky any more for a few days.
TODO: