[opteadm] Add show-xde-underlay command.#1013
Open
daniel-levin wants to merge 1 commit into
Open
Conversation
This command only adds value for debugging and development purposes. It is unlikely to be of much value in the field. It is acutely useful for experimenting with different combinations of underlying macs, such as this Chelsio and Mellanox contraption: $ opteadm show-xde-underlay LINK MTU MAC mlxcx0 9000 6C:B3:11:88:AC:84 cxgbe1 9000 00:07:43:2F:E6:C8 Signed-off-by: Daniel Levin <daniel.levin@oxidecomputer.com>
daniel-levin
requested review from
FelixMcFelix
and removed request for
rzezeski
FelixMcFelix
approved these changes
Jul 1, 2026
FelixMcFelix
left a comment
FelixMcFelix
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, I think this looks good! Even if the answer is what we expect 99.9% of the time, it's useful to have in the toolbox to actively confirm that underlay config is set in dev/production debugging I'd think.
Comment on lines
+498
to
+499
| /// Tack on 'Resp' to the name to avoid polluting | ||
| /// the space of symbols in XDE-proper. |
Collaborator
There was a problem hiding this comment.
This probably shouldn't be a doc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command only adds value for debugging and development purposes. It is unlikely to be of much value in the field. It is acutely useful for experimenting with different combinations of underlying macs, such as this Chelsio and Mellanox contraption: