Add board definition for Waveshare ESP32-S3 Touch LCD 1.28

[shantanu-pai]

This code contains additional "memory_type" parameter in the "build" block ,"-DARDUINO_USB_MODE=1", parameter in the "extra_flags": block and a different "speed": argument in the "upload" block compared to #1332 .

The discussion during writing of this code can be seen here

The code was written by @maxgerhardt when I needed it for my own project. I have tested the same on my Waveshare ESP32-S3 Touch LCD 1.28 and can confirm that it works. I'm putting this here so that it can be officially supported by PlatformIO's board manager.

This closes #1323

[valeros]

Hi @scar027, thanks for the PR. This board requires Arduino core v3.0 which is not officially supported yet.

[sivar2311]

Hi @valeros !
I can't see any requirement for Arduino 3.x since this is an S3 based board!?

[maxgerhardt]

The board JSON's

"variant": "waveshare_esp32s3_touch_lcd_128"

references

https://github.com/espressif/arduino-esp32/tree/3.0.2/variants/waveshare_esp32s3_touch_lcd_128

but this is not available in 2.x

https://github.com/espressif/arduino-esp32/tree/2.0.17/variants/waveshare_esp32s3_touch_lcd_128

[sivar2311]

Thanks @maxgerhardt for the clearification!

[shantanu-pai]

Thank you for the response @valeros. Do you recommend that I keep this open so that this can be incorporated when Arduino core v3.0 is officially supported or should I close the PR?

[valeros]

@scar027 Let's keep it open