Subtensor lift: reason about advanced indices jointly when gating#2251
Open
ricardoV94 wants to merge 2 commits into
Open
Subtensor lift: reason about advanced indices jointly when gating#2251ricardoV94 wants to merge 2 commits into
ricardoV94 wants to merge 2 commits into
Conversation
ricardoV94
force-pushed
the
proper_idx_gating
branch
from
30aa289 to
c27a1c3
Compare
ricardoV94
force-pushed
the
proper_idx_gating
branch
from
c27a1c3 to
1fabcb8
Compare
ricardoV94
force-pushed
the
proper_idx_gating
branch
from
1fabcb8 to
483c1b9
Compare
ricardoV94
force-pushed
the
proper_idx_gating
branch
from
483c1b9 to
f63da68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had heuristics that work per-axis, but we should reason about the advanced indices together since they interact. E.g., tril_indices, would fail the per-axis checks, as each index (row, col) is larger than the respective axis and contains duplicates. But jointly they index less than the full array and don't have duplicates, so we want to lift it through Elemwise and the like.
Shows up in pymc-devs/pymc#8297